revert OIDC IdP CA to use RSA keys in new suites #46792
Merged
+77
−54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nklaassen
added
the
no-changelog
rosstimothy
approved these changes
Sep 20, 2024
zmb3
approved these changes
Sep 20, 2024
public-teleport-github-review-bot
bot
removed request for
ravicious and
gzdunek
nklaassen
force-pushed
the
nklaassen/revert-oidc-ca
branch
from
0b90c06
to
43e8308
Compare
nklaassen
changed the base branch from
nklaassen/default-auth-pref
to
master
|
🤖 Vercel preview here: https://docs-jd681bew6-goteleport.vercel.app/docs/ver/preview |
I never actually updated any of our OIDC IdP code to support ECDSA, it actually just doesn't support it at all. It also goes against the OIDC spec to not support the RS256 algorithm for id_token_signing_alg_values_supported, which we wouldn't be able to support if we didn't have an RSA key. I've already reverted the SAML IdP as well. We'll need a different strategy to offer both RSA and ECDSA in the future.
nklaassen
force-pushed
the
nklaassen/revert-oidc-ca
branch
from
43e8308
to
dccda3b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I never actually updated any of our OIDC IdP code to support ECDSA, it actually just doesn't support it at all.
It also goes against the OIDC spec to not support the RS256 algorithm for
id_token_signing_alg_values_supported, which we wouldn't be able to support if we didn't have an RSA key.I've already reverted the SAML IdP as well. We'll need a different strategy to offer both RSA and ECDSA in the future.