fix: tsh await request resolution expired #52327
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
size/sm
tsh
zmb3
reviewed
Feb 19, 2025
| @@ -5281,7 +5281,9 @@ func awaitRequestResolution(ctx context.Context, clt authclient.ClientI, req typ | |||
| return nil, trace.BadParameter("unexpected resource type %T", event.Resource) | |||
There was a problem hiding this comment.
We probably shouldn't update reqState here if this is for a different access request.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating and waiting for an access to be approved, if another access request is expired, it should not fail my await.
Example:
You can see the access request ID that expired is not the ID of the access request Im waiting for approval.