Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GitHub proxy: cleanup git servers when deleting the integration #52333

Merged
merged 2 commits into from
Feb 21, 2025
Merged

GitHub proxy: cleanup git servers when deleting the integration #52333

merged 2 commits into from
Feb 21, 2025
+243 −7

Conversation

greedy52
Copy link
Contributor

@greedy52 greedy52 commented Feb 20, 2025 •
edited
Loading

@greedy52 greedy52 added do-not-merge no-changelog Indicates that a PR does not require a changelog entry labels Feb 20, 2025
@greedy52 greedy52 self-assigned this Feb 20, 2025
@greedy52 greedy52 force-pushed the STeve/github_integration_cleanup branch 2 times, most recently from e645f53 to e88c13e Compare February 20, 2025 17:30
@greedy52 greedy52 force-pushed the STeve/github_integration_cleanup branch from e88c13e to 42ef1a6 Compare February 20, 2025 17:37
@greedy52 greedy52 requested review from zmb3 and kimlisa February 20, 2025 17:38
@greedy52 greedy52 added backport/branch/v17 github-integration GitHub integration related and removed do-not-merge labels Feb 20, 2025
zmb3
zmb3 reviewed Feb 20, 2025
View reviewed changes
@greedy52 greedy52 marked this pull request as ready for review February 20, 2025 20:54
@greedy52 greedy52 requested a review from zmb3 February 20, 2025 20:55
zmb3
zmb3 approved these changes Feb 20, 2025
View reviewed changes
Copy link
Collaborator

@zmb3 zmb3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though I wonder if atomic writes would help to remove all items in a single operation. Maybe check with @fspmarshall - he's the expert.

kimlisa
kimlisa approved these changes Feb 20, 2025
View reviewed changes
Copy link
Contributor

@kimlisa kimlisa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TYSM for this! much more solid than my own attempt 🙃

@kimlisa kimlisa mentioned this pull request Feb 21, 2025
Open
1 task
@greedy52 greedy52 added this pull request to the merge queue Feb 21, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 21, 2025
@greedy52 greedy52 added this pull request to the merge queue Feb 21, 2025
Merged via the queue into master with commit eab2980 Feb 21, 2025
90 checks passed
@greedy52 greedy52 deleted the STeve/github_integration_cleanup branch February 21, 2025 15:23
@public-teleport-github-review-bot
Copy link

@greedy52 See the table below for backport results.

Branch Result
branch/v17 Failed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zmb3 zmb3 zmb3 approved these changes

@kimlisa kimlisa kimlisa approved these changes

Assignees

@greedy52 greedy52

Labels
backport/branch/v17 github-integration GitHub integration related no-changelog Indicates that a PR does not require a changelog entry size/md
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@greedy52 @zmb3 @kimlisa