Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add required field indicators to labels #52343

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

bl-nero
Copy link
Contributor

@bl-nero bl-nero commented Feb 20, 2025

This PR unifies the way we display labels across different types of input fields and adds consistent support for required field markers and info tooltips. Actually reusing these in places where fields are created manually, circumventing the built-in input fields, is not in the scope.

Screenshot 2025-02-20 at 10 53 16
Screenshot 2025-02-20 at 10 53 39
Screenshot 2025-02-20 at 10 53 48
Screenshot 2025-02-20 at 11 12 59

Tested:

  • in Storybook
  • in the role editor (with a follow-up PR that applies these to selected fields)
  • app connection UI in teleterm

Contributes to #52036
Followed up by #52345

Copy link
Contributor

@avatus avatus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me. Idk why seeing the label content as a child of the input doesn't sit well with me but, i won't die on that hill. (and maybe its normal, idk? never really used label inputs enough to know i guess)

@bl-nero
Copy link
Contributor Author

bl-nero commented Feb 21, 2025

Looks fine to me. Idk why seeing the label content as a child of the input doesn't sit well with me but, i won't die on that hill. (and maybe its normal, idk? never really used label inputs enough to know i guess)

@avatus Label content is never a child of the input, it's just the name that is confusing (and we might want to simply rename it someday). LabelInput is actually an "input label".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/branch/v16 backport/branch/v17 no-changelog Indicates that a PR does not require a changelog entry size/md ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants