Truncate DiscoveryConfig.Status ErrorMessage #52347
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcoandredinis
added
no-changelog
Some fetchers might generate a lot of errors which are aggregated and sent to the `DiscoveryConfig.Status.ErrorMessage`. This might cause gRPC clients to fail when listing DiscoveryConfigs with a `grpc: received message larger than max (xyz vs. 4194304)` error. Allowing 100KB for the error message should give the user enough context on what's causing the errors.
marcoandredinis
force-pushed
the
marco/discoveryconfig_status_truncate_errormessage
branch
from
f614dc2 to
fbecdf2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some fetchers might generate a lot of errors which are aggregated and sent to the
DiscoveryConfig.Status.ErrorMessage.This might cause gRPC clients to fail when listing DiscoveryConfigs with a
grpc: received message larger than max (xyz vs. 4194304)error.Allowing 100KB for the error message should give the user enough context on what's causing the errors.