Add story for ResourceActionButton
#52886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ravicious
added
no-changelog
ravicious
commented
Mar 7, 2025
| ); | ||
| } | ||
|
|
||
| return context; |
There was a problem hiding this comment.
This change should not change the behavior of the hook. Previously if there was no context, the callsite would throw an error while trying to destructure the return value. Now the function itself is going to throw a more meaningful error.
avatus
approved these changes
Mar 7, 2025
zmb3
approved these changes
Mar 7, 2025
public-teleport-github-review-bot
bot
removed the request for review
from gzdunek
|
@ravicious See the table below for backport results.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a story for
ResourceActionButtonthat's similar to a story for action buttons in teleterm. The context is that I'm going to work on a modal for TCP apps that's shown when you try to connect to a TCP app from the Web UI, so I wanted to have an overview of how other buttons work.