-
Notifications
You must be signed in to change notification settings - Fork 6
feat: new layer for styling with CSS #142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Preview is ready. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, I like the solution and the code, and I'm ready to accept it, but I want to ask you:
— fix the problem with typecheck on CI;
— write a small documentation on the new layer — describe what this layer provides and how to use it.
return ( | ||
<div className="css-variables-story"> | ||
<div className="controls"> | ||
<div className="control-group"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
JFYI: You can use Gravity UIKit, it's already listed in dev-deps and it's used in other stories.
This pull request solves the problem of styling and setting variables for the Graph component using CSS variables.
An example of usage can be found in the corresponding Storybook.
#104