feat: Add helpers to subsribe events for GraphComponent #189
+185
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Preview is ready. |
Copilot finished reviewing on behalf of
astandrik
November 15, 2025 09:31
There was a problem hiding this comment.
Pull Request Overview
This PR adds two convenience helper methods to GraphComponent for subscribing to events with automatic cleanup on component unmount.
- Adds
onGraphEventmethod for subscribing to graph events - Adds
onRootEventmethod for subscribing to DOM events on the root element - Includes comprehensive test coverage for both new methods and cleanup behavior
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/components/canvas/GraphComponent/index.tsx | Adds two protected helper methods (onGraphEvent and onRootEvent) that wrap event subscriptions and register cleanup handlers |
| src/components/canvas/GraphComponent/GraphComponent.test.ts | Adds comprehensive tests verifying event subscription and automatic cleanup on unmount for both helper methods |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
draedful
approved these changes
Nov 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #183