-
Notifications
You must be signed in to change notification settings - Fork 90
gpadvs-search-exact-match.js: Added snippet to enable exact match functionality with GP Advanced Select.
#1128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
saifsultanc
wants to merge
1
commit into
master
Choose a base branch
from
saif/add/85959-add-snippet-exact-match-gpas
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,35 @@ | ||
| /** | ||
| * Gravity Perks // Advanced Select // Search For Exact Match | ||
| * https://gravitywiz.com/documentation/gravity-forms-advanced-select/ | ||
| * | ||
| * By default, Advanced Select will return any item whose label contains the search query. This | ||
| * snippet will change the search algorithm to only return items whose label matches the | ||
| * search query exactly. | ||
| * | ||
| * Instruction Video: https://www.loom.com/share/4266734e5ab14870ba6b8bba28d01f68 | ||
| * | ||
| * Instructions: | ||
| * | ||
| * 1. Install this snippet with our free Custom JavaScript plugin. | ||
| * https://gravitywiz.com/gravity-forms-code-chest/ | ||
| */ | ||
| gform.addFilter( 'gpadvs_settings', function( settings, gpadvs ) { | ||
| settings.score = function(search) { | ||
| if ( ! search ) { | ||
| return function() { | ||
| // Item has no search query, return all items | ||
| return 1; | ||
| }; | ||
| } | ||
| search = search.toLowerCase(); | ||
| return function(item) { | ||
| if ( item.text.toLowerCase() === search ) { | ||
| // High score for items matching search query exactly | ||
| return 1; | ||
| } | ||
| // Zero score for items not matching search query | ||
| return 0; | ||
| }; | ||
| }; | ||
| return settings; | ||
| } ); | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Add defensive programming for safer property access.
The exact match logic is sound, but there's a potential runtime error if
item.textis undefined, null, or not a string. Consider adding a safety check before callingtoLowerCase().Apply this diff to add defensive programming:
search = search.toLowerCase(); return function(item) { - if ( item.text.toLowerCase() === search ) { + if ( item.text && typeof item.text === 'string' && item.text.toLowerCase() === search ) { // High score for items matching search query exactly return 1; } // Zero score for items not matching search query return 0; };This ensures the code gracefully handles cases where
item.textmight be undefined, null, or not a string, preventing potential JavaScript errors.📝 Committable suggestion
🤖 Prompt for AI Agents