gpeb-display-stars-for-rating-fields.php: Added customizable SVG star with empty star display option for rating fields.
#1143
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ar with empty star display option for rating fields.
WalkthroughThe code now renders rating fields using configurable SVG-based stars instead of repeated star characters. It introduces a configuration array for star appearance, updates field values to SVG markup based on ratings, and adds a function to decode HTML-encoded SVGs for proper display. Relevant filters are updated to apply these changes. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant EntryDisplay
participant SVGRenderer
participant SVGDecoder
User->>EntryDisplay: View entry with rating field
EntryDisplay->>SVGRenderer: Render rating field as SVG stars
SVGRenderer-->>EntryDisplay: Return SVG star markup
EntryDisplay->>SVGDecoder: Decode HTML-encoded SVGs in content
SVGDecoder-->>EntryDisplay: Return decoded content
EntryDisplay-->>User: Display entry with SVG stars
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Note 🔌 MCP (Model Context Protocol) integration is now available in Early Access!Pro users can now connect to remote MCP servers under the Integrations page to get reviews and chat conversations that understand additional development context. 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
🧹 Nitpick comments (3)
gp-entry-blocks/gpeb-display-stars-for-rating-fields.php (3)
16-16: Optional: prefer CSS color via currentColor for simpler themingIf you’re open to CSS-driven theming, set stroke="currentColor" on the base SVG and control colors with the wrapper/container class. Keep fill/color on the variants as you do now.
-$star_svg = '<svg ... stroke="' . esc_attr( $star_color ) . '" ...> +$star_svg = '<svg ... stroke="currentColor" ...>Then set the color via CSS on .gpeb-rating, and keep the inline fill for filled vs outline variants as-is. This makes per-context color overrides trivial without regenerating the SVG string.
44-45: Hook names look correct; update callback if you rename itIf you adopt the function prefixing, point the filters at the new name.
-add_filter('gpeb_loop_entry_content', 'decode_rating_field_svgs', 10, 3); -add_filter('gpeb_view_entry_content', 'decode_rating_field_svgs', 10, 3); +add_filter( 'gpeb_loop_entry_content', 'gpeb_decode_rating_field_svgs', 10, 3 ); +add_filter( 'gpeb_view_entry_content', 'gpeb_decode_rating_field_svgs', 10, 3 );
7-17: General: small robustness and DX tweaks
- Consider exposing an additional config key 'total_stars' to override count($field->choices) when needed (e.g., legacy entries with mismatched choices). You can default to count($field->choices) when not provided.
- Optionally add an 'empty_star_stroke_color' to differentiate outline color from filled color.
- Add brief attribution comment for Feather icon in the header if your project requires third‑party asset attribution.
Happy to update the PR with the above changes if you want me to push a patch.
Also applies to: 23-27, 36-45
saifsultanc
approved these changes
Aug 9, 2025
…ar with empty star display option for rating fields.
…ar with empty star display option for rating fields.
saifsultanc
approved these changes
Aug 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
⛑️ Ticket(s): https://secure.helpscout.net/conversation/3021474440/87220?viewId=8172236
Summary
This PR addresses a feature request that would allow the user to display empty stars after the filled stars, as well as being able to change the color.
Changes:
Quick demo of the changes: https://www.loom.com/share/591fd8930a5f476aa3c381ec8606b610