Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to disable cookie fallback #244

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Option to disable cookie fallback #244

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 15 additions & 2 deletions src/angular-local-storage.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,9 @@ angularLocalStorage.provider('localStorageService', function() {

// You could change web storage type localstorage or sessionStorage
this.storageType = 'localStorage';

// Define if cookie fallback should be used when localStorage fails
this.cookieFallback = true;

// Cookie options (usually in case of fallback)
// expiry = Number of days before cookies expire // 0 = Does not expire
Expand All @@ -38,6 +41,12 @@ angularLocalStorage.provider('localStorageService', function() {
this.storageType = storageType;
return this;
};

// Setter for the cookieFallback switch
this.setCookieFallback = function(cookieFallback) {
this.cookieFallback = !!cookieFallback;
return this;
};

// Setter for cookie config
this.setStorageCookie = function(exp, path) {
Expand Down Expand Up @@ -121,7 +130,7 @@ angularLocalStorage.provider('localStorageService', function() {
}

// If this browser does not support local storage use cookies
if (!browserSupportsLocalStorage || self.storageType === 'cookie') {
if ((!browserSupportsLocalStorage && self.cookieFallback) || self.storageType === 'cookie') {
if (!browserSupportsLocalStorage) {
$rootScope.$broadcast('LocalStorageModule.notification.warning', 'LOCAL_STORAGE_NOT_SUPPORTED');
}
Expand All @@ -139,7 +148,11 @@ angularLocalStorage.provider('localStorageService', function() {
}
} catch (e) {
$rootScope.$broadcast('LocalStorageModule.notification.error', e.message);
return addToCookies(key, value);
if(self.cookieFallback) {
return addToCookies(key, value);
} else {
return false;
}
}
return true;
};
Expand Down