Skip to content

Add user agent #137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add user agent #137

wants to merge 1 commit into from

Conversation

snipe
Copy link
Member

@snipe snipe commented Jul 16, 2025

This just adds a User-Agent string to the headers.

@snipe
Added user-agent
19dc512 
Signed-off-by: snipe <[email protected]>
@snipe snipe changed the base branch from develop to main July 16, 2025 13:50
ParadoxGuitarist
ParadoxGuitarist approved these changes Jul 16, 2025
View reviewed changes
Copy link
Collaborator

@ParadoxGuitarist ParadoxGuitarist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

  • A nitpick would be to bump the version number at line 33 to 1.0.8 so you have a quick way of telling if customers are using the latest version or not, but if y'all don't use it that much it's a moot point and not worth blocking. Hope you both are well!

@jerm
Copy link
Member

jerm commented Jul 17, 2025

That's not much of a blocker, tbqh, and it's a behavior change, even if it's innocuous. I'd prefer to see the version bump as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ParadoxGuitarist ParadoxGuitarist ParadoxGuitarist approved these changes

@uberbrady uberbrady Awaiting requested review from uberbrady

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@snipe @jerm @ParadoxGuitarist