Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the error happened while loading remote code #614

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Vampire
Copy link
Contributor

@Vampire Vampire commented Jan 10, 2025

Without this for example the stackoverflow error "maybe code is not highlighted properly" is swallowed and only shown in JS console,
while in the error tab it only says "maybe the NoScript extension is causing problems".
Now the error is also displayed.

@leonard84
Copy link
Collaborator

Is there error helpful and not confusing for the average user?

@Vampire
Copy link
Contributor Author

Vampire commented Feb 5, 2025

Imho yes.
As I said, if you e.g. use the SO integration and choose a question without groovy formatted code currently you see "noscript plugin maybe interferes" while that is not the problem.
With this change it displays the "maybe the code in the question is not formatted as Groovy" message so it is clear what the problem is and can be fixed in the SO question.

@leonard84 leonard84 enabled auto-merge February 6, 2025 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants