chore: Update dependencies and do a small refactor #242
+147
−150
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
|
Collaborator
|
Sorry I couldn't get to this timely, you might wanna rebase go.{mod,sum} from HEAD as they're auto-merged from dependabot bumps now. |
Author
|
Sure @ahmetb, updated the code, so you can take a look again. |
Collaborator
|
Sorry this got out of sync again. :( |
Author
|
Our company switched away from grpc-health-probe, so I'm not sure it's worth me keeping this PR up to date with any changes. I guess if you review the PR and approve it (since there will not be any functional changes), then I can resolve the conflicts and immediately merge it. Otherwise it's probably easier if I just close it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates all the Go dependencies to their latest versions, updates workflow files a bit and does a small refactor, such as fixing typos and following best practices.
grpc.DialContext still needs to be updated, but I don't have enough experience with it or with this tool to be confident that I properly used it (due to the changes in the name resolver or the state changes).