grpclb: Refactoring GrpclbLoadBalancerTest unit tests #11677
+705
−751
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h Duration" This reverts commit ab97045.
shivaspeaks
reviewed
Nov 11, 2024
| verify(helper, times(4)).refreshNameResolution(); | ||
| } | ||
|
|
||
| private StreamObserver<LoadBalanceResponse> getFastForwardBeforeRetry(int nanos, InOrder inOrder, |
There was a problem hiding this comment.
I see the work done by this method aptly suggests it's name to be - fastForwardAndRetry()
There was a problem hiding this comment.
Renamed the method
shivaspeaks
reviewed
Nov 11, 2024
| assertEquals(0, fakeClock.numPendingTasks(LB_RPC_RETRY_TASK_FILTER)); | ||
|
|
||
| // Balancer closes it immediately (erroneously) | ||
| lbResponseObserver.onCompleted(); |
There was a problem hiding this comment.
Move this out to main test method.
There was a problem hiding this comment.
Handled as suggested, please review
shivaspeaks
reviewed
Nov 11, 2024
| assertEquals(1, lbRequestObservers.size()); | ||
| StreamObserver<LoadBalanceRequest> lbRequestObserver = lbRequestObservers.poll(); | ||
| verify(lbRequestObserver).onNext(eq(expectedInitialRequest)); | ||
| assertEquals(0, fakeClock.numPendingTasks(LB_RPC_RETRY_TASK_FILTER)); |
There was a problem hiding this comment.
The assertions and verifications here are very common. Can be done differently?
There was a problem hiding this comment.
Moved to different method, please review
…_pickFirstMode_lbSendsEmptyAddress
…d, grpclbFallback_allLost_failToFallback, switchMode and its related testcases
|
I believe the requirement was to break down tests that perform multiple actions into smaller, independent tests, rather than simply making the existing tests more modular—which is beneficial but not the main focus. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactoring Unit Test cases for GrpclbLoadBalancerTest.
Fixes #2772