-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Start 1.73.0 development cycle #11986
Conversation
@@ -95,11 +95,11 @@ public static void main(String[] args) throws IOException, InterruptedException | |||
server.blockUntilShutdown(); | |||
} | |||
|
|||
static class GreeterImpl extends GreeterGrpc.GreeterImplBase { | |||
static class GreeterImpl extends io.grpc.examples.helloworld.GreeterGrpc.GreeterImplBase { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Revert this file
@@ -19,6 +19,8 @@ dependencies { | |||
libraries.animalsniffer.annotations, | |||
libraries.guava | |||
implementation libraries.errorprone.annotations | |||
implementation project(path: ':grpc-api') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Revert this file.
@@ -400,7 +400,7 @@ grpc-netty version | netty-handler version | netty-tcnative-boringssl-static ver | |||
1.59.x | 4.1.97.Final | 2.0.61.Final | |||
1.60.x-1.66.x | 4.1.100.Final | 2.0.61.Final | |||
1.67.x-1.70.x | 4.1.110.Final | 2.0.65.Final | |||
1.71.x- | 4.1.110.Final | 2.0.70.Final | |||
1.72.0-SNAPSHOT- | 4.1.110.Final | 2.0.70.Final |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How did these changes come about? 1.71.x- still applies.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review comments.
No description provided.