Skip to content

Conversation

zrlw
Copy link
Contributor

@zrlw zrlw commented Jul 15, 2025

#12215
Guava seems to call a deprecated sun.misc.Unsafe::objectFieldOffset method which might be removed in a future JDK release.
There are still a few things to do for -android versions, which are tracked in google/guava#7742,
see details at google/guava#7811

Copy link

linux-foundation-easycla bot commented Jul 15, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

@zrlw zrlw force-pushed the guava-33.4.8-jre branch from db60d82 to bf9cfba Compare July 15, 2025 02:16
@zrlw zrlw force-pushed the guava-33.4.8-jre branch from bf9cfba to 497c16c Compare July 15, 2025 02:40
@zrlw zrlw changed the title Upgrade guava version to 33.4.8-jre Upgrade guava version to 33.4.8 Jul 15, 2025
@shivaspeaks shivaspeaks added the kokoro:run Add this label to a PR to tell Kokoro the code is safe and tests can be run label Jul 15, 2025
@grpc-kokoro grpc-kokoro removed the kokoro:run Add this label to a PR to tell Kokoro the code is safe and tests can be run label Jul 15, 2025
@zrlw
Copy link
Contributor Author

zrlw commented Jul 16, 2025

# error-prone 2.31.0+ blocked on https://github.com/grpc/grpc-java/issues/10152
# It breaks Bazel (ArrayIndexOutOfBoundsException in turbine) and Dexing ("D8:
# java.lang.NullPointerException"). We can trivially upgrade the Bazel CI to
# 6.3.0+ (https://github.com/bazelbuild/bazel/issues/18743).

According to https://issuetracker.google.com/issues/342522142#comment8 (Jun 6, 2024):

This was fixed in D8/R8 compilers a little more than a year ago. The issue tracking this on D8/R8 is b/281536562, but that is an internal bug.
The fix landed in 8.3.3-dev, and was part of AGP 8.3. It was backported to 8.1.44 and 8.0.46 for AGP 8.1 and 8.0.
It was not backported to D8/R8 4.0 for AGP 7.4. However, you should be able to use D8/R8 8.0.44 or 8.1.44 with AGP 7.4 if needed. To use a specific D8/R8 version merge the following into settings.gradle or settings.gradle.kts:

pluginManagement {
    buildscript {
        repositories {
            mavenCentral()
            maven {
                url = uri("https://storage.googleapis.com/r8-releases/raw")
            }
        }
        dependencies {
            classpath("com.android.tools:r8:8.1.44")
        }
    }
}

@zrlw
Copy link
Contributor Author

zrlw commented Jul 16, 2025

@shivaspeaks PTAL

@ejona86
Copy link
Member

ejona86 commented Jul 17, 2025

We're trying to get a release made (v1.74.0). Once it is made, we'll look at bumping the dependency versions.

@ejona86 ejona86 added the kokoro:run Add this label to a PR to tell Kokoro the code is safe and tests can be run label Aug 20, 2025
@grpc-kokoro grpc-kokoro removed the kokoro:run Add this label to a PR to tell Kokoro the code is safe and tests can be run label Aug 20, 2025
@ejona86
Copy link
Member

ejona86 commented Aug 20, 2025

We should look at getting this in, as it also fixes the errorprone-annotations problem. We should double-check whether the D8 NPE also is triggered for our users as well, as then we can point them to the workaround in case they are impacted. (Although that's not strictly necessary.)

Copy link
Member

@ejona86 ejona86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirmed that the NPE error propagates to our examples, so it is necessary to update them. We'll need to notify users in our release notes.

Thank you so much!

@ejona86
Copy link
Member

ejona86 commented Aug 29, 2025

(FYI: nobody should need to wait for us to upgrade dependencies like Guava. Newer versions of dependencies should generally be fine. We only discourage downgrading dependencies.)

@ejona86 ejona86 added the kokoro:run Add this label to a PR to tell Kokoro the code is safe and tests can be run label Aug 29, 2025
@grpc-kokoro grpc-kokoro removed the kokoro:run Add this label to a PR to tell Kokoro the code is safe and tests can be run label Aug 29, 2025
@ejona86 ejona86 merged commit d9509b5 into grpc:master Aug 29, 2025
14 of 16 checks passed
@zrlw
Copy link
Contributor Author

zrlw commented Aug 30, 2025

I confirmed that the NPE error propagates to our examples, so it is necessary to update them. We'll need to notify users in our release notes.

Thank you so much!

You are welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants