Skip to content

android-interop-testing : working on clearing lint warnings #12272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

android-interop-testing : working on clearing lint warnings #12272

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
734dc7a
android-interop-testing : working on clearing lint warnings
Sangamesh1997 Aug 13, 2025
09597f3
android-interop-testing : working on clearing lint warnings
Sangamesh1997 Aug 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions android-interop-testing/src/main/AndroidManifest.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,9 @@
<uses-permission android:name="android.permission.INTERNET" />
<!-- For UDS -->
<uses-permission android:name="android.permission.READ_EXTERNAL_STORAGE"/>
<uses-permission android:name="android.permission.WRITE_EXTERNAL_STORAGE"/>
<uses-permission
android:name="android.permission.WRITE_EXTERNAL_STORAGE"
android:maxSdkVersion="28" />
<uses-sdk tools:overrideLibrary="io.grpc.android"/>

<application
Expand All @@ -16,8 +18,7 @@
android:name="androidx.multidex.MultiDexApplication">
<activity
android:name=".TesterActivity"
android:exported="true"
android:label="@string/app_name" >
android:exported="true">
<intent-filter>
<action android:name="android.intent.action.MAIN" />

Expand Down
2 changes: 1 addition & 1 deletion android-interop-testing/src/main/java/io/grpc/android/integrationtest/TesterActivity.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ private void startTest(String testCase) {
((InputMethodManager) getSystemService(Context.INPUT_METHOD_SERVICE)).hideSoftInputFromWindow(
hostEdit.getWindowToken(), 0);
enableButtons(false);
resultText.setText("Testing...");
resultText.setText(R.string.testing_message);

String host = hostEdit.getText().toString();
String portStr = portEdit.getText().toString();
Expand Down
1 change: 1 addition & 0 deletions android-interop-testing/src/main/res/layout/activity_tester.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
android:layout_weight="2"
android:layout_width="0dp"
android:layout_height="wrap_content"
android:inputType="text"
android:hint="Enter Host"
/>
<EditText
Expand Down
1 change: 1 addition & 0 deletions android-interop-testing/src/main/res/values/strings.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
<resources>
<string name="app_name">gRPC Integration Test</string>
<string name="testing_message">Testing…</string>
</resources>
13 changes: 11 additions & 2 deletions binder/src/main/AndroidManifest.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,11 @@
<manifest xmlns:android="http://schemas.android.com/apk/res/android" >
</manifest>
<manifest xmlns:android="http://schemas.android.com/apk/res/android">

<queries>

<intent>
<action android:name="android.intent.action.VIEW" />
</intent>

</queries>

</manifest>
5 changes: 5 additions & 0 deletions lint.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,4 +5,9 @@
Remove after AGP upgrade.
-->
<issue id="OldTargetApi" severity="ignore" />

<!--
Suppress temporarily 'VisibleForTests' warnings - exposed for testing purposes
-->
<issue id="VisibleForTests" severity="ignore" />
</lint>
Loading