Fix some issues with the benchmark code #2523
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change in
any_grpc.js
allows code packaging tools such aspkg
to correctly process thatrequire
call.The old
grpc
library is now an optional dependency, so that installation of other packages can proceed if in environments where that package is not supported, particularly when the runtime is a newer version of Node.When calling
RunServer
on a worker with aport
of0
, the response now reports the actual bound port instead of0
.The new
worker.js
is there for manual testing. It expects two workers to be running at the specified ports onlocalhost
, and it instructs them to run a simple benchmark.