Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some issues with the benchmark code #2523

Merged
merged 1 commit into from
Jul 27, 2023

Conversation

murgatroid99
Copy link
Member

The change in any_grpc.js allows code packaging tools such as pkg to correctly process that require call.

The old grpc library is now an optional dependency, so that installation of other packages can proceed if in environments where that package is not supported, particularly when the runtime is a newer version of Node.

When calling RunServer on a worker with a port of 0, the response now reports the actual bound port instead of 0.

The new worker.js is there for manual testing. It expects two workers to be running at the specified ports on localhost, and it instructs them to run a simple benchmark.

@murgatroid99 murgatroid99 merged commit 4a8ec12 into grpc:master Jul 27, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants