New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

grpc-js-xds: Fix a couple of bugs with the config tears change #2845

Merged

murgatroid99 merged 1 commit into grpc:master from murgatroid99:grpc-js-xds_config_tears_fixes

Nov 7, 2024

Member

murgatroid99 commented Nov 7, 2024

This change fixes two significant bugs introduced in #2844:

pick_first reported IDLE instead of TRANSIENT_FAILURE when provided a zero-length address list. This caused all calls to queue for LB picks instead of ending with an error, which means that they piled up quickly.
As a consequence of the way in-use clusters were retained, the xDS dependency manager would provide the config again every time a call was committed (or at least most of the time).


          grpc-js-xds: Fix a couple of bugs with the config tears change

eee7030

murgatroid99 merged commit 83b6e60 into grpc:master

4 of 10 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet