Add process-wide client diagnostics observers - #51
Draft
NghiaTranUIT wants to merge 1 commit into
Draft
Conversation
|
NghiaTranUIT
force-pushed
the
codex/client-diagnostics-observer
branch
from
July 13, 2026 07:20
53fa875 to
c77c0c2
Compare
NghiaTranUIT
force-pushed
the
codex/client-diagnostics-observer
branch
from
July 13, 2026 07:31
c77c0c2 to
6bacc77
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #50.
Summary
Implementation
Instrumentation sits in ClientRPCExecutor and ClientStreamExecutor, after client interceptors and serialization but before transport compression and TLS. Attempt terminal events are finalized after outbound and inbound work stops, so payload events cannot arrive after attemptFinished.
Safety
Registration is explicit and process-local. Documentation warns that observers receive potentially sensitive metadata and serialized payloads and must return quickly from synchronous callbacks.
Testing
This remains a draft for maintainer feedback on the API and whether a gRFC or a repository-owned benchmark target is required.