Add code gen config for the module name #2201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modifications: - Add config to the code generator allowing a different module name to be specified. - Remove unused code Result: The grpc module name can be specified in generated code
|
The API breakage checker is a false positive, this is a |
|
The examples are failing on nightly-main and nightly-next because of grpc/grpc-swift-nio-transport#69 (which is yet to be released). |
|
Why do we need this exactly? Just for testing? If so, can we not make the new |
gjcairo
approved these changes
Feb 28, 2025
| return self.grpcCore + "." + type | ||
| } | ||
|
|
||
| func serverRequest(forType type: String?, streaming: Bool) -> ExistingTypeDescription { |
There was a problem hiding this comment.
Nit: I think having isStreaming in all these funcs instead of streaming makes it more consistent with requestResponse (and it's also more idiomatic).
Suggested change
| func serverRequest(forType type: String?, streaming: Bool) -> ExistingTypeDescription { | |
| func serverRequest(forType type: String?, isStreaming: Bool) -> ExistingTypeDescription { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modifications:
Result:
The grpc module name can be specified in generated code