chore: bump bazel modules#1526
Conversation
* bump protobuf to 29.1 * removed not longer required java single override * removed rules_proto due deprecation * migrated x_proto_library targets to protobuf * set default bazel version to 8.6.0
There was a problem hiding this comment.
Pull request overview
Updates the repository’s Bazel module/dependency setup to align with newer protobuf/Bazel tooling and remove deprecated proto rules usage.
Changes:
- Bumps
protobufBazel module dependency to29.1and updatesrules_ccto0.2.17. - Removes
rules_protoand the no-longer-neededgrpc-javasingle-version override. - Adds
.bazelversionto default the repo to Bazel8.6.0, and updates an example BUILD file to use protobuf-provided proto rules.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
net/grpc/gateway/examples/echo/BUILD.bazel |
Switches proto_library/cc_proto_library loads to protobuf-provided bzl files. |
MODULE.bazel |
Updates module/dependency versions and removes deprecated/obsolete module entries. |
.bazelversion |
Pins the default Bazel version to 8.6.0. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| name = "grpc-web", | ||
| version = "1.6.0", | ||
| compatibility_level = 1, | ||
| version = "2.0.2", |
There was a problem hiding this comment.
module() no longer sets compatibility_level. Since the module version is now 2.0.2, leaving compatibility_level unset defaults it to 0, which can break Bazel module version resolution/compatibility semantics for downstream users. Consider setting compatibility_level = 2 (or otherwise explicitly documenting/choosing the intended compatibility level) to match the major versioning scheme previously used here (1.6.0 had compatibility_level = 1).
| version = "2.0.2", | |
| version = "2.0.2", | |
| compatibility_level = 2, |
There was a problem hiding this comment.
The attribute 'compatibility_level' in module() is a no-op and will be removed in a future Bazel release. Please remove it from your MODULE.bazel file
we should remove it
sampajano
left a comment
sampajano
left a comment
There was a problem hiding this comment.
Thanks for working on this change, @loeffel-io ! 😃
@Vuhag123 Could you also take a look and help monitor this process?
ok Eryu will look into this. |
Head branch was pushed to by a user without write access
|
missed the echo example |
|
kokoro looks good now - fails for the same reason as last master commit 1bcab08 |
|
@loeffel-io Great, Thanks! @Vuhag123 Could you look into the error that is happening and whether it's a real failure on the main branch? Thanks! |
to bring the grpc-web module finally to bcr we should bump the grpc-web bazel modules
after this we can bump bazelbuild/bazel-central-registry#2541