-
Notifications
You must be signed in to change notification settings - Fork 247
L124: C-core: Server-wide max_outstanding_streams #494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
siddharthnohria
wants to merge
4
commits into
grpc:master
Choose a base branch
from
siddharthnohria:max_concurrent_streams
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,43 @@ | ||
| Title | ||
| ---- | ||
| * Author(s): Siddharth Nohria <siddharthnohria> | ||
| * Approver: Craig Tiller <ctiller> | ||
| * Status: Draft | ||
| * Implemented in: C++ | ||
| * Last updated: 2025-05-12 | ||
| * Discussion at: <google group thread> (filled after thread exists) | ||
|
|
||
| ## Abstract | ||
|
|
||
| Allow servers to set a server-wide `MAX_CONCURRENT_STREAMS` as part of the | ||
| Resource Quota, in addition to the current per-connection `MAX_CONCURRENT_STREAMS`. | ||
|
|
||
| ## Background | ||
|
|
||
| HTTP2 protocol provides the `MAX_CONCURRENT_STREAMS` setting as a way to limit | ||
| the number of concurrently open streams on any single connection between a | ||
| client and the server. | ||
|
|
||
| But this in itself is not good enough to protect the servers from too many | ||
| concurrent streams; a client can just create create more connections to the same | ||
| server, and be allowed to effectively send more concurrent streams. | ||
|
|
||
| In addition to the overload risk due too many connections, another limitation of | ||
| a per-connection `MAX_CONCURRENT_STREAMS` is that it is static in nature. For | ||
| servers where the number of clients might be dynamic, this is sub-optimal. When | ||
| there are only a few clients connected to the server, the server might be able | ||
| to server more concurrent requests from each of these clients. So a | ||
| per-connection limit set to deal with overload situations (with 1000's of clients) | ||
| might be sub-optimal in situations with only a small number of clients. | ||
|
|
||
| ## Proposal | ||
|
|
||
| Introduce `StreamQuota` as part of the `ResourceQuota` on the server side. Users | ||
| can set the `max_outstanding_streams` in the `StreamQuota`, which will be equally | ||
| distributed among all open connections to the server. If the user also specifies | ||
| a per-connection `MAX_CONCURRENT_STREAMS`, that will also be respected as an | ||
| upper bound. | ||
|
|
||
| ## Implementation | ||
|
|
||
| Implemented in https://github.com/grpc/grpc/pull/39125. | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please start the groups thread so that the 2wk timer starts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.