L126: C-core: Support ALTS Credentials in Google Default Credentials #504
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rockspore
reviewed
Jun 30, 2025
Contributor
rockspore
left a comment
rockspore
left a comment
There was a problem hiding this comment.
Thanks for writing up the proposal! Made some comments assuming we are fine with scoping this as a C-Core only gRFC.
I'll defer the gRPC TLs to decide whether an across-language one is needed (and I can help with that if so).
Member
|
FYI: #496 is also L123 |
Contributor
Author
Modify the numnber. |
anniefrchz
changed the title
markdroth
reviewed
Jul 7, 2025
markdroth
reviewed
Jul 16, 2025
markdroth
changed the title
markdroth
reviewed
Jul 16, 2025
markdroth
reviewed
Aug 22, 2025
markdroth
reviewed
Aug 22, 2025
markdroth
reviewed
Aug 22, 2025
markdroth
approved these changes
Aug 25, 2025
Member
markdroth
left a comment
markdroth
left a comment
There was a problem hiding this comment.
Just one minor nit remaining. Feel free to merge after fixing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.