L127: C++: SPIFFE Bundle Map support in Providers #506
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markdroth
changed the title
markdroth
changed the title
markdroth
reviewed
Jul 16, 2025
|
Did you forget to push some of the changes? I don't see any but the first comment addressed. |
|
My bad - editor confusion when moving the file from L123 to L127. Should be good now |
markdroth
approved these changes
Jul 17, 2025
markdroth
approved these changes
Jul 18, 2025
L127-cpp-spiffe-root-provider.md
Outdated
| This proposal _only_ aims to support file-based SPIFFE Bundle Maps via the file watcher providers. The `StaticDataCertificateProvider` structure is left as future work. This will involve broadening the API surface to expose a type for the SPIFFE bundle map. | ||
|
|
||
| ## Implementation | ||
| PR will be linked when created. |
There was a problem hiding this comment.
I think you can list all of the PRs you've been working on that are directly related to this effort:
- [Security] Add a SPIFFE ID parser grpc#39148
- [Security] Add support for parsing SPIFFE Bundle Maps from JSON grpc#39445
- [Security - XDS] Add Spiffe Bundle Map support to providers grpc#39708
You can add to the list as you finish the remaining work.
copybara-service bot
pushed a commit
to grpc/grpc
that referenced
this pull request
Aug 11, 2025
This PR adds APIs discussed in grpc/proposal#506 and https://github.com/grpc/proposal/blob/master/A87-mtls-spiffe-support.md to support verification with SPIFFE Bundle Map roots. RELEASE NOTES: * Adds support for SPIFFE Bundle Maps in as roots of trust per [gRFC A87](https://github.com/grpc/proposal/blob/master/A87-mtls-spiffe-support.md) and [gRFC L127](grpc/proposal#506) Closes #40321 COPYBARA_INTEGRATE_REVIEW=#40321 from gtcooke94:spiffe_verification 6ddc24e PiperOrigin-RevId: 793688101
eugeneo
pushed a commit
to eugeneo/grpc
that referenced
this pull request
Aug 11, 2025
) This PR adds APIs discussed in grpc/proposal#506 and https://github.com/grpc/proposal/blob/master/A87-mtls-spiffe-support.md to support verification with SPIFFE Bundle Map roots. RELEASE NOTES: * Adds support for SPIFFE Bundle Maps in as roots of trust per [gRFC A87](https://github.com/grpc/proposal/blob/master/A87-mtls-spiffe-support.md) and [gRFC L127](grpc/proposal#506) Closes grpc#40321 COPYBARA_INTEGRATE_REVIEW=grpc#40321 from gtcooke94:spiffe_verification 6ddc24e PiperOrigin-RevId: 793688101
gtcooke94
added a commit
to grpc/grpc
that referenced
this pull request
Aug 21, 2025
Cherry pick #40476 to 1.75 RELEASE NOTES: * Adds support for SPIFFE Bundle Maps in as roots of trust per [gRFC A87](https://github.com/grpc/proposal/blob/master/A87-mtls-spiffe-support.md) and grpc/proposal#506
paulosjca
pushed a commit
to paulosjca/grpc
that referenced
this pull request
Aug 23, 2025
) This PR adds APIs discussed in grpc/proposal#506 and https://github.com/grpc/proposal/blob/master/A87-mtls-spiffe-support.md to support verification with SPIFFE Bundle Map roots. RELEASE NOTES: * Adds support for SPIFFE Bundle Maps in as roots of trust per [gRFC A87](https://github.com/grpc/proposal/blob/master/A87-mtls-spiffe-support.md) and [gRFC L127](grpc/proposal#506) Closes grpc#40321 COPYBARA_INTEGRATE_REVIEW=grpc#40321 from gtcooke94:spiffe_verification 6ddc24e PiperOrigin-RevId: 793688101
asheshvidyut
pushed a commit
to asheshvidyut/grpc
that referenced
this pull request
Sep 12, 2025
) This PR adds APIs discussed in grpc/proposal#506 and https://github.com/grpc/proposal/blob/master/A87-mtls-spiffe-support.md to support verification with SPIFFE Bundle Map roots. RELEASE NOTES: * Adds support for SPIFFE Bundle Maps in as roots of trust per [gRFC A87](https://github.com/grpc/proposal/blob/master/A87-mtls-spiffe-support.md) and [gRFC L127](grpc/proposal#506) Closes grpc#40321 COPYBARA_INTEGRATE_REVIEW=grpc#40321 from gtcooke94:spiffe_verification 6ddc24e PiperOrigin-RevId: 793688101
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.