Skip to content

172 - Artifact Carousel Overflow fix #237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AlexGarneau wants to merge 2 commits into
base: main
Choose a base branch
from
Open

172 - Artifact Carousel Overflow fix #237

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b5ed998
Added an overlap mode to the Artifact Carousel text for incredibly sm…
AlexGarneau Dec 9, 2025
56a8978
Set 4 Padding to styles.insets and autoformatter formatted things.
AlexGarneau Dec 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion lib/ui/screens/artifact/artifact_carousel/artifact_carousel_screen.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,8 @@ class _ArtifactScreenState extends State<ArtifactCarouselScreen> {
@override
Widget build(BuildContext context) {
bool shortMode = context.heightPx <= 800;
final double bottomHeight = context.heightPx / 2.75; // Prev 340, dynamic seems to work better
bool overlapMode = context.heightPx <= 450;
final double bottomHeight = context.heightPx / (overlapMode ? 2 : 2.75); // Prev 340, dynamic seems to work better
// Allow objects to become wider as the screen becomes tall, this allows
// them to grow taller as well, filling the available space better.
double itemHeight = (context.heightPx - 200 - bottomHeight).clamp(250, 400);
Expand Down Expand Up @@ -122,6 +123,7 @@ class _ArtifactScreenState extends State<ArtifactCarouselScreen> {
artifact: _artifacts[value],
height: bottomHeight,
shortMode: shortMode,
overlapMode: overlapMode,
state: this,
),
),
Expand Down
36 changes: 26 additions & 10 deletions lib/ui/screens/artifact/artifact_carousel/widgets/_bottom_text_content.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,16 +2,30 @@ part of '../artifact_carousel_screen.dart';

class _BottomTextContent extends StatelessWidget {
const _BottomTextContent(
{super.key, required this.artifact, required this.height, required this.state, required this.shortMode});
{super.key,
required this.artifact,
required this.height,
required this.state,
required this.shortMode,
required this.overlapMode});

final HighlightData artifact;
final double height;
final _ArtifactScreenState state;
final bool shortMode;
final bool overlapMode;
int get _currentPage => state._currentPage.value.round();

@override
Widget build(BuildContext context) {
Widget textContent = Text(
artifact.title,
overflow: TextOverflow.ellipsis,
style: $styles.text.h2.copyWith(color: $styles.colors.black, height: 1.2, fontSize: 32),
textAlign: TextAlign.center,
maxLines: 2,
);

return Container(
width: $styles.sizes.maxContentWidth2,
height: height,
Expand Down Expand Up @@ -40,13 +54,15 @@ class _BottomTextContent extends StatelessWidget {
SizedBox(width: double.infinity),
// Stop text from scaling to make layout a little easier, it's already quite large
StaticTextScale(
child: Text(
artifact.title,
overflow: TextOverflow.ellipsis,
style: $styles.text.h2.copyWith(color: $styles.colors.black, height: 1.2, fontSize: 32),
textAlign: TextAlign.center,
maxLines: 2,
),
child: overlapMode
? Container(
padding: EdgeInsets.all($styles.insets.xxs),
decoration: BoxDecoration(
borderRadius: BorderRadius.circular($styles.corners.md),
color: $styles.colors.white.withAlpha(130),
),
child: textContent)
: textContent,
),
if (!shortMode) ...[
Gap($styles.insets.xxs),
Expand All @@ -70,13 +86,13 @@ class _BottomTextContent extends StatelessWidget {
controller: state._pageController!,
semanticPageTitle: $strings.artifactsSemanticArtifact,
),
Gap($styles.insets.md),
if (!shortMode) Gap($styles.insets.md),
AppBtn.from(
text: $strings.artifactsButtonBrowse,
expand: true,
onPressed: state._handleSearchTap,
),
Gap($styles.insets.lg),
if (!shortMode) Gap($styles.insets.lg) else Gap($styles.insets.md),
],
),
],
Expand Down