Add volume directive to ECS Dockerfile
#40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
AWS FSBP ECS.5 states that root container filesystems must be readonly. We can specify particular directories as exceptions to this by using ephemeral volumes such as bind mounts. Specifying a
VOLUMEin the Dockerfile, means that when we intantiate a container using this image, we can set the directory specified by theVOLUMEcommand as a mount point, and it's contents will not be erased.How to test
We have tested this by running this container with a mount point at
/init, and have verified that it is able to run as normal, indicating the files were not destroyed when the volume was mounted.How can we measure success?
We see fewer ECS.5 failures, as we no longer need root filesystem write access to make changes to the
/initfolder