Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.8] Summarize the multibytes body stream comfortable #589

Open
wants to merge 2 commits into
base: 2.7
Choose a base branch
from

Conversation

TheNorthMemory
Copy link

solved #588

Copy link

stale bot commented Apr 22, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed after 2 weeks if no further activity occurs. Thank you for your contributions.

@GrahamCampbell
Copy link
Member

I'm not sure I like this approach, as it assumes UTF-8 encoding. If we are to make that assumption, this implementation seems over-complex. Would it not be simpler to fetch 4x the bytes and then use mb_substr?

@stale stale bot removed the lifecycle/stale label Jul 18, 2024
@GrahamCampbell GrahamCampbell changed the title summarize the multibytes body stream comfortable [2.8.] Summarize the multibytes body stream comfortable Jul 18, 2024
@GrahamCampbell GrahamCampbell changed the title [2.8.] Summarize the multibytes body stream comfortable [2.8] Summarize the multibytes body stream comfortable Jul 18, 2024
@GrahamCampbell GrahamCampbell changed the base branch from 2.6 to 2.7 July 18, 2024 10:19
@TheNorthMemory
Copy link
Author

yes, indeed, using mb_substr is better than manual detection. I saw that comment #561 as for few dependencies reason so it's leave the ext-mb alone. If this package should be required the ext-mb, I've happy to see using the sample way patch the Malformed UTF-8 characters issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants