V239 changes #5031
Merged
V239 changes #5031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Report significance fit info in sngls_findtrigs * Report significance calculation info in statmap jobs * Fix typo, fix test * TD comments, some tidying up * neaten comments * comment fix --------- Co-authored-by: Thomas Dent <[email protected]>
titodalcanton
added
v23_release_branch
|
I think we also need #4901 for the tests to pass. |
|
Merged #4901 now, though I doubt this will be the only one. I'll also try and figure out how to built a singularity image that will be able to transfer OSDF files with the current pegasus release. |
* try macos latest version * move to update macos on build as well
* tox: fix tox integration with conda use setup-miniconda github action and specify more packages in conda_deps for each testenv * tox: install ligo-segments and python-ligo-lw with conda these packages don't install cleanly with pypi, but the conda packages have patches * test: use numpy.longdouble instead of float128 float128 isn't available on macOS ARM64 * tox: clean up duplicate package lists * ci: unpin tox * tox: further simplify duplicate configuration
spxiwh
commented
Feb 6, 2025
spxiwh
commented
Feb 7, 2025
|
Should we incorporate #5034 (and getting this into the workflow), or just merge as-is as we can do another release which contains those? |
GarethCabournDavies
approved these changes
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not yet ready to be merged, but I'll log the changes for the v239 release here. I expect some compatibility issues will require some other patches to be added, but will let the test suite tell me.
I think GWOSC is down right now, so we may have to wait for that to be fixed.