PyGRB: minor fixes to workflow generator #5038
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Standard information about the request
This is a: bug fix.
This change affects: PyGRB
This change changes: PyGRB workflow generation.
Motivation
This PR contains 2 separate bugfixes uncovered while testing the code on single detector GRB runs using O4a data.
Contents
pycbc_make_offline_grb_workflow
checks for veto segments present in the onsource timewindow, i.e. around the GRB trigger, and throws an error if that's the case to avoid submitting jobs and end up wasting CPU hours.Currently lines 252-264 lack an if statement to avoid operating with an empty list, when
avail_segs
has no elements.pycbc/workflow/jobsetup.py
. Specifically lines 690&691 were mistakenly using the methodget_opts
from the wrong object.