Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PyGRB: minor fixes to workflow generator #5038

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

sebastiangomezlopez
Copy link
Contributor

@sebastiangomezlopez sebastiangomezlopez commented Feb 11, 2025

Standard information about the request

This is a: bug fix.

This change affects: PyGRB

This change changes: PyGRB workflow generation.

Motivation

This PR contains 2 separate bugfixes uncovered while testing the code on single detector GRB runs using O4a data.

Contents

  1. In the context of handling Veto definer files, pycbc_make_offline_grb_workflow checks for veto segments present in the onsource timewindow, i.e. around the GRB trigger, and throws an error if that's the case to avoid submitting jobs and end up wasting CPU hours.

Currently lines 252-264 lack an if statement to avoid operating with an empty list, when avail_segs has no elements.

  1. Single detector runs were not tested in the past. However by recently doing so, we uncovered a minor bug in pycbc/workflow/jobsetup.py. Specifically lines 690&691 were mistakenly using the method get_opts from the wrong object.

Minor bugfix related to single detector runs
Fixing the workflow generator for the case in which veto definer files  are empty for a specific detector.
@sebastiangomezlopez sebastiangomezlopez self-assigned this Feb 11, 2025
@sebastiangomezlopez sebastiangomezlopez added PyGRB PyGRB development bug labels Feb 11, 2025
@sebastiangomezlopez sebastiangomezlopez changed the title PyGRB: minor fixes for workflow generator PyGRB: minor fixes to workflow generator Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug PyGRB PyGRB development
Projects
Status: Changes Requested
Development

Successfully merging this pull request may close these issues.

2 participants