Unpin lalsuite version #5040
Unpin lalsuite version #5040
Conversation
|
Don't you also need to change something here? https://github.com/gwastro/pycbc/blob/master/.github/workflows/basic-tests.yml#L31-L37 |
|
Huh, HDF5 errors and a segfault, interesting… |
I think they're the same error, and I think it originates with me not understanding git lfs ... Grumble, grumble, grumble ... Moving to a direct curl instead, I understand curl. |
|
But the segfault is indicative of a bigger problem, potentially an unchecked error condition in lalsimulation. |
That's probably right .... But I'm not sure I want to go down that rabbit hole. Jolien's HDF code did fail, so I suspect that SEOB carried on with a |
.github/workflows/basic-tests.yml
Outdated
| @@ -35,6 +35,7 @@ jobs: | |||
| git lfs pull -I "data/lalsimulation/SEOBNRv4ROM_v2.0.hdf5" | |||
| mv data/lalsimulation/* ../ | |||
| cd ../ | |||
| curl https://git.ligo.org/waveforms/software/lalsuite-waveform-data/-/raw/main/waveform_data/SEOBNRv4ROM_v3.0.hdf5 > SEOBNRv4ROM_v3.0.hdf5 | |||
There was a problem hiding this comment.
| curl https://git.ligo.org/waveforms/software/lalsuite-waveform-data/-/raw/main/waveform_data/SEOBNRv4ROM_v3.0.hdf5 > SEOBNRv4ROM_v3.0.hdf5 | |
| curl --show-error --silent --remote-name https://git.ligo.org/waveforms/software/lalsuite-waveform-data/-/raw/main/waveform_data/SEOBNRv4ROM_v3.0.hdf5 |
There was a problem hiding this comment.
In fact, we may as well just use curl for the files above and get rid of all git/cd/mv commands, including the installation of git-lfs.
There was a problem hiding this comment.
SEOBNR_v2_ROM is like 20 separate files, which might be messy. But let me see if just getting the v4 files is sufficient now.
There was a problem hiding this comment.
Drop the > redirects, that is the point of --remote-name.
The various data files needed for lalsuite are now available publically again (lalsuite will inform the user of this if the user does not have the files in their path).
Therefore I unpin lalsuite. I've dumped the new SEOBNR file into our existing CVMFS directory so the CI will need no more changes.
To confirm SEOBNRv4_ROM_v3 is identical to SEOBNRv4_ROM_v2 (it just contains a certain bit of metadata that is irrelevant for us).
This would be needed for #5019 (and a lalsuite release that uses igwn-ligolw, if that doesn't already exist).