Skip to content

TreeSet/TreeMap should implement Cloneable and offer clone() #10146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 20, 2025

Conversation

niloc132
Copy link
Member

Fixes #10145

Copy link
Collaborator

@zbynek zbynek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. There is no speed optimization (it should be possible to clone the map without sorting everything), but that's already noted in

putAll(map); // TODO(jat): more efficient init from sorted map

@niloc132
Copy link
Member Author

RIght, this doesn't fix that issue at all. I have a draft that tried to fix how we load the data, but it isn't good enough to be worth even putting up a draft yet.

@niloc132 niloc132 merged commit 1fdf4cf into gwtproject:main Aug 20, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TreeSet and TreeMap don't support clone()
2 participants