Skip to content

Apple Privacy Manifest #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mattiacantalu wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Apple Privacy Manifest #16

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d624541
feat: fix close button always hidden issue
ZurabiKobakhidze Jan 5, 2024
396b6fe
Merge pull request #1 from YNAP/gymshark/defect/close_button_hidden
ZurabiKobakhidze Jan 5, 2024
9828b59
feat(privacy): adding privacy manifest
mattiacantalu Jan 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 4 additions & 7 deletions Package.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,25 +7,22 @@ let package = Package(
name: "SharkCardScan",
platforms: [ .iOS(.v13)],
products: [
// Products define the executables and libraries a package produces, and make them visible to other packages.
.library(
name: "SharkCardScan",
targets: ["SharkCardScan"]),
],
dependencies: [
// Dependencies declare other packages that this package depends on.
// .package(url: /* package url */, from: "1.0.0"), dependencies: [
.package(
.package(
name: "SharkUtils",
url: "https://github.com/gymshark/ios-shark-utils.git",
.exact("1.0.5")),
],
targets: [
// Targets are the basic building blocks of a package. A target can define a module or a test suite.
// Targets can depend on other targets in this package, and on products in packages this package depends on.
.target(
name: "SharkCardScan",
dependencies: ["SharkUtils"]),
dependencies: ["SharkUtils"],
path: "Sources",
resources: [.copy("Resources/PrivacyInfo.xcprivacy")]),
.testTarget(
name: "SharkCardScanTests",
dependencies: ["SharkCardScan"]),
Expand Down
35 changes: 35 additions & 0 deletions Sources/Resources/PrivacyInfo.xcprivacy
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,35 @@
<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
<plist version="1.0">
<dict>
<key>NSPrivacyCollectedDataTypes</key>
<array>
<dict>
<key>NSPrivacyCollectedDataType</key>
<string>NSPrivacyCollectedDataTypeName</string>
<key>NSPrivacyCollectedDataTypeLinked</key>
<true/>
<key>NSPrivacyCollectedDataTypeTracking</key>
<false/>
<key>NSPrivacyCollectedDataTypePurposes</key>
<array>
<string>NSPrivacyCollectedDataTypePurposeAppFunctionality</string>
</array>
</dict>
<dict>
<key>NSPrivacyCollectedDataType</key>
<string>NSPrivacyCollectedDataTypePaymentInfo</string>
<key>NSPrivacyCollectedDataTypeLinked</key>
<true/>
<key>NSPrivacyCollectedDataTypeTracking</key>
<false/>
<key>NSPrivacyCollectedDataTypePurposes</key>
<array>
<string>NSPrivacyCollectedDataTypePurposeAppFunctionality</string>
</array>
</dict>
</array>
<key>NSPrivacyTracking</key>
<false/>
</dict>
</plist>
2 changes: 1 addition & 1 deletion Sources/SharkCardScan/SharkCardScanViewController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ public class SharkCardScanViewController: UIViewController {
private var styling: CardScanStyling

private lazy var closeButton = UIButton().with {
$0.setBackgroundImage(UIImage(named: "rounded close"), for: .normal)
$0.setBackgroundImage(UIImage(named: "rounded close", in: Bundle.module, compatibleWith: nil), for: .normal)
$0.accessibilityLabel = String(describing: SharkCardScanViewController.self) + "." + "CloseButton"
}

Expand Down