Support custimozed minDE via xml and adaptive HDF5 chunking size #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tai271828
commented
Dec 16, 2025
|
|
||
| // *** Calculating LB parameters using Re on the inlet: Re = U_avg * D / nu | ||
| void calcSimulationParameters(SimPar &sim, T dx, T dt = -1, T U_max_LB_ = 0.1) | ||
| { |
Author
There was a problem hiding this comment.
I have collected the style updates for removing trailing whitespace into a single commit. Therefore, it will be more efficient to review this pull request commit-by-commit.
Author
tai271828
commented
Dec 16, 2025
| if( stat( pathName.c_str(), &info ) != 0 ) | ||
| return -1; // Cannot acces path | ||
| else if( info.st_mode & S_IFDIR ) // S_ISDIR() doesn't exist on my windows | ||
| else if( info.st_mode & S_IFDIR ) // S_ISDIR() doesn't exist on my windows |
Author
There was a problem hiding this comment.
I noticed that io.cpp uses LF line terminators, while hemoflow.cpp uses CRLF. I am not sure if this is intentional. We can discuss it on Thursday.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request introduces two features:
minDE: ParsesminDEdirectly from the XML file, making it easier to customize.Both features significantly reduce development turnaround time. By introducing adaptive chunking, we can run simulations with smaller geometries and obtain results faster. This is particularly beneficial when working on the C++ components of hemoFlow. Additionally, this serves as the cornerstone for establishing a manageable CI pipeline in the future.
Verification Steps
Run hemoFlow with the following command:
testcase/test_SimpleTube_Freeflow.xmlNote that
testcase/test_SimpleTube_Freeflow.xmlmimicstestcase/test_Freeflow.xmlbut utilizes a simpler geometry and flow rate. The corresponding geometry.npzand flow rate files have been generated and included in this pull request.