Skip to content

Conversation

marc101101
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Feb 26, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 72.22%. Comparing base (93a25d1) to head (a4b9db2).

❗ Current head a4b9db2 differs from pull request most recent head 86de137. Consider uploading reports for the commit 86de137 to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main     #102       +/-   ##
===========================================
- Coverage   82.70%   72.22%   -10.49%     
===========================================
  Files          47        5       -42     
  Lines        1376      108     -1268     
  Branches      168       25      -143     
===========================================
- Hits         1138       78     -1060     
+ Misses        238       30      -208     
Flag Coverage Δ
backend ?
frontend 72.22% <75.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
frontend/src/config.ts 95.45% <100.00%> (ø)
frontend/src/components/base/button.tsx 86.20% <66.66%> (ø)

... and 50 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 93a25d1...86de137. Read the comment docs.

@marc101101 marc101101 requested a review from phntxx March 24, 2025 19:10
@marc101101 marc101101 self-assigned this Mar 24, 2025
# - name: test
# uses: borales/[email protected]
# with:
# cmd: backend::test
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are tests really failing

* Get all users
* @returns all users
*/
public async getAllUsers(): Promise<readonly UserListDto[]> {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

extend comment

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

getSemiAnyomouseUsers()

/**
* Get all users
*/
public async getAllUsers(): Promise<UserListDto[]> {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

getSemiAnyomouseUsers()

/**
* Get user list only with names and ids
*/
@Get("/list")
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

getSemiAnyomouseUsers()

/>
<div style={{ marginTop: "1rem" }}>
<MuiButton
href="whatsapp://send?text=I am visiting Hackaburg this year! Join me at https://hackaburg.de"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whatsapp invite raus

to: string;
children: string;
children: any;
}
Copy link
Contributor Author

@marc101101 marc101101 Mar 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is children?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

correct type or comment

import { Page } from "./page";
import { saveAs } from "file-saver";
import { Divider } from "../base/divider";
import { BsGenderFemale, BsGenderMale } from "react-icons/bs";
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

show also non-binary gender in application form

<TableCell onClick={handleExpandRow}>{email}</TableCell>
<TableCell onClick={handleExpandRow}>{name}</TableCell>
<TableCell onClick={handleExpandRow}>{teamNumber}</TableCell>
<TableCell onClick={handleExpandRow}>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

extend

RowComponent = AdmittedRow;
}

const cityIndex = questions.find((q) => q.title === "City")?.id!;
Copy link
Contributor Author

@marc101101 marc101101 Mar 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

city / country / gender is mandatory in settings => add comment in subheadline

@marc101101 marc101101 changed the title Feat/teams feat: teams Mar 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants