[Announcement] Exclude events with disabled monthly announcements in scope #11401
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the problem
#11299 starte deleting monthly announcements when they were disabled in event configuration and added a check to
monthly_job, but there were still places where themonthlyscope was being used without checking if the event had disabled monthly announcements, and there are some monthly announcements in the database for events that have disabled it.Describe your changes
Moves the check for disabled monthly announcements to the
monthlyscope, ensuring no monthly announcement is listed for an event that has disabled them. Also removes the now-redundant checks for the configuration.