Repository navigation
fix(dashboard): retry pixel credits and stop silently swallowing payout failures - #198
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
creditProjectPixels()logged database RPC errors but returned success. Approval and post-approval correction callers could continue and report a payout as completed when the credit never applied.Change
credit_project_pixelsdatabase RPC is idempotent: it applies the delta from the already-credited project amount, so bounded retries are safe.IMPORTANT LIMITATION
Approval state is updated before credits are issued. This PR improves failure detection but is NOT a full atomic approval-and-payout fix. If every credit attempt fails, the project can still remain approved without a payout. Full remediation requires a transactional approval/credit or a persistent reconciler with recorded payout snapshots; don't claim this patch closes that entire class.
No production balance adjustments or database writes were performed manually. CI pending.