feat: Rich text input using Plate.js in forms #144
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZeroWave022
changed the title
seandreassen
requested changes
Oct 12, 2025
There was a problem hiding this comment.
Surprisingly little code in here that isn't from plate. There are a few problems with how the rich text input works.
- Adding text or rich input without pressing enter to create a new "group" of text doesn't make the form not pristine. You're not allowed to press the submit button.
- Adding rich input without creating a new "group" in the same field makes it so the media isn't saved in the input, only in our files.
- You have to click off a rich input field to update the form pristine state, meaning you can't edit a rich input field then click submit, you have to click off first.
- I'm guessing it's not that easy to delete uploaded media from our files when they're deleted in the rich input, but also add that if possible.
| }); | ||
| })() | ||
| ) : ( | ||
| <span>Pick a date</span> |
There was a problem hiding this comment.
Unfortunately, cannot translate this because
- The next-intl context is unavailable, so the translations are missing as well
- We cannot get the context, because the components must be rendered synchronously to work with Plate.js HTML serialization.
The lack of translations only affects exported files. I've added a comment about this where appropriate.
| ) : ( | ||
| <div className='flex h-7 w-full items-center gap-2 whitespace-nowrap text-muted-foreground text-sm'> | ||
| <RadicalIcon className='size-6 text-muted-foreground/80' /> | ||
| <div>Add a Tex equation</div> |
There was a problem hiding this comment.
Unfortunately, cannot translate this because
- The next-intl context is unavailable, so the translations are missing as well
- We cannot get the context, because the components must be rendered synchronously to work with Plate.js HTML serialization.
The lack of translations only affects exported files. I've added a comment about this where appropriate.
Must use debounced onChange here, because if we process the content on every keypress, the input becomes extremely laggy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR guidelines/tips:
components/ui/platedo not a need thorough review. These files come from Plate and have been slightly adjusted to make them i18n-compatible and I've made them fit our code style guidelines more.