-
Notifications
You must be signed in to change notification settings - Fork 0
feat: Landing page #158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
feat: Landing page #158
Conversation
Also fixed images filling screen
This reverts commit d16f96f.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should also consider adding the possibility to add "banners" at the top of the screen, informing about some temporary state (e.g. the workshop being closed for the winter or summer vacations). Slides should be named slides in Norwegian as well, and then we can use the name banner for both languages for this temporary state information at the top of the screen.
It is up to you whether banners should be a part of this PR. If you don't know what banner I'm talking about, you can go to the old website and try to enable a banner in the admin panel
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We do not use all of the width available, so the event titles and such are truncated very early. If you want to, you can tinker a bit more with it so we use more of the space. If not, we can leave it for a later PR.
Is having a carousel filling the whole screen a good idea? If so, I think the animation speed on the image change should be reduced, as it is very aggressive atm
onSuccess: async (_data, variables) => { | ||
toast.success( | ||
variables.active | ||
? t.successfullyChangedToActive | ||
: t.successfullyChangedToInactive, | ||
); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
onSuccess: async (_data, variables) => { | |
toast.success( | |
variables.active | |
? t.successfullyChangedToActive | |
: t.successfullyChangedToInactive, | |
); | |
onSuccess: async () => { |
<Checkbox | ||
checked={changeSlideActive.variables?.active ?? slide.active} | ||
onCheckedChange={(value) => { | ||
changeSlideActive.mutate({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changeSlideActive.mutate({ | |
const promise = changeSlideActive.mutateAsync({ |
changeSlideActive.mutate({ | ||
id: slide.id, | ||
active: value !== 'indeterminate' ? value : false, | ||
}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
}); | |
}); | |
toast.promise(promise, { | |
loading: 't.changingToActive', | |
success: slide.active | |
? t.successfullyChangedToInactive | |
: t.successfullyChangedToActive, | |
error: 't.errorChangingActiveState', | |
}); |
Added landing page with automatically changing slides. Admin users can add or edit existing slides with new text or images.