Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Epic: Check in bug tracker and resolution #1838

Open
2 of 6 tasks
JackHaeg opened this issue Jan 21, 2025 · 5 comments
Open
2 of 6 tasks

Epic: Check in bug tracker and resolution #1838

JackHaeg opened this issue Jan 21, 2025 · 5 comments
Labels
Bug complexity: large draft Not ready for prioritization yet Epic/Overview Contains a list of other issues or an overview of issue p-feature: Check In Research Researching best approach/solutions role: Back End size: Epic Size not relevant (epic issue)

Comments

@JackHaeg
Copy link
Member

JackHaeg commented Jan 21, 2025

Overview

Associated check in bug issues:

Current overview of Check In Bug per @trillium:

Overview:

  • We have accurate timestamps for when the event should start, but the timestamp's date creation is happening sometimes on the day before because of timezone differences between Pacific Time and GMT.
  • So, we need to update the backend function to take into account timezone differences of the base timestamp vs. now.

Here's a summary of what happens with events on VRMS:

  • A recurring event is generated or updated
    • The front end sends a timestamp with the user's selected time to the backend
    • The backend stores that timestamp in GMT
  • Periodically (weekly) the backend runs a script checking to see if any events happen on a day of the week (e.g., Thursday).
    • Within this bucket of events, a new date is generated in today's time and then the hour of that now current timestamp is set to the same hour as the stored recurring event hour.
    • Come check in time, a separate script is run to see if any of the events should be considered open (I believe the window is 30 min before start time and 30 min after the end of the event).
    • If the event's date is off, due to it being created in the wrong timezone (e.g., GMT vs. PST), then when the hour is assigned, the time is roughly off by 1 day or +/- 1 hour.

Action Items

Need to employ test-driven development to resolve this issue.

Resources/Instructions

@JackHaeg JackHaeg added Bug Epic/Overview Contains a list of other issues or an overview of issue p-feature: Check In role: Back End size: Epic Size not relevant (epic issue) labels Jan 21, 2025
@JackHaeg JackHaeg added this to the 04.01 Existing Features milestone Jan 21, 2025
@github-project-automation github-project-automation bot moved this to New Issue Approval in P: VRMS: Project Board Jan 21, 2025
@JackHaeg JackHaeg moved this from New Issue Approval to Epic Issues in P: VRMS: Project Board Jan 21, 2025
@JackHaeg JackHaeg added Research Researching best approach/solutions draft Not ready for prioritization yet labels Jan 21, 2025
@kurtmgray kurtmgray assigned kurtmgray and unassigned kurtmgray Jan 21, 2025
@JackHaeg
Copy link
Member Author

@trillium what do you think our timeline will be in terms of rebuilding Dev & Prod with this fix in place?

I'd love to test on both Dev & Prod to ensure that meeting times & check-ins are working properly. Then we can make an announcement to the PMs that the issue has been fixed and they can start using VRMS again to check in to events.

@trillium
Copy link
Member

We triggered rebuild of Dev just now, will monitor and follow up

@JackHaeg
Copy link
Member Author

JackHaeg commented Feb 20, 2025

Progress update: Backend build currently failing due to build action failure reasons unrelated to the PR. Once backend is rebuilt, additional testing can be completed and if all checks are passed, then the issues contained within this epic can be resolved.

@JackHaeg
Copy link
Member Author

JackHaeg commented Mar 4, 2025

  • Kurt's fix will be implemented in Dev, which was rebuilt on 3.3.2025. Conduct testing on Dev to see if events are displayed properly.

@JackHaeg
Copy link
Member Author

JackHaeg commented Mar 6, 2025

@kurtmgray @trillium

After implementing Kurt's fix on Dev and testing this week, it appears that at least some issues are continuing to occur.

  • For example, testing in Central Time Zone on March 6, 2025 at 11:38am CDT:
    • There is one meeting available to check in at 11:38am CDT: "!!! Polygon - 3pm Thurs Polygon MTG"
    • This meeting is reportedly scheduled for "5 - 7:30pm" CDT.
    • The "Manually Edit Events Checkin" displays that the meeting is available for check in from 9:00-11:00am.
Screenshots

Image Image

Another example of Check in Issue with Project: "!!! GMX!!!!!! trillium" at 4:34PM Central Time

Image

  • Meeting "ts.TimingBug--Thursday8pm" shows as available for check in at 4:34pm Central Time.
  • As you can see from the Recurring Events, this Event is scheduled for check in at 10pm - 12pm Central (i.e., 8-10pm Pacific as the name suggests)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug complexity: large draft Not ready for prioritization yet Epic/Overview Contains a list of other issues or an overview of issue p-feature: Check In Research Researching best approach/solutions role: Back End size: Epic Size not relevant (epic issue)
Projects
Status: Epic Issues
Development

No branches or pull requests

3 participants