Removed Facebook eventPrompt; Fixed typo in application submission; A…

…dded phone number field to account creation. (#1005) Co-authored-by: Joshua Zhou <[email protected]>
hackmcgill · Nov 1, 2024 · 6a5c274 · 6a5c274
1 parent 19fe744
commit 6a5c274
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 23 deletions.
diff --git a/src/config/constants.ts b/src/config/constants.ts
@@ -143,7 +143,7 @@ export const TRAVEL_REQUEST_REASON_LABEL = 'Reason';
 export const PREVIOUS_HACKATHONS_LABEL =
   'How many hackathons have you been to?';
 export const REVIEW_APPLICIATION_DESCRIPTION =
-  'Your are about to submit. Please review your application before submitting. You won’t be able to edit your responses later.';
+  'You are about to submit. Please review your application before submitting. You won’t be able to edit your responses later.';
 
 // Invite Page
 export const ACCOUNT_TYPE_LABEL = 'Account type';

diff --git a/src/features/Account/ManageAccountForm.tsx b/src/features/Account/ManageAccountForm.tsx
@@ -281,18 +281,21 @@ const ManageAccountForm: React.FC<IManageAccountProps> = (props) => {
             name={'newPassword'}
           />
           <ErrorMessage component={FormikElements.Error} name="newPassword" />
-          <FastField
-            component={FormikElements.FormattedNumber}
-            label={CONSTANTS.PHONE_NUMBER_LABEL}
-            placeholder="+# (###) ###-####"
-            format="+# (###) ###-####"
-            name={'phoneNumber'}
-            required={true}
-            value={fp.values.phoneNumber}
-          />
-          <ErrorMessage component={FormikElements.Error} name="phoneNumber" />
         </>
       )}
+
+      <FastField
+        component={FormikElements.FormattedNumber}
+        label={CONSTANTS.PHONE_NUMBER_LABEL}
+        placeholder="+# (###) ###-####"
+        format="+# (###) ###-####"
+        name={'phoneNumber'}
+        required={true}
+        value={fp.values.phoneNumber}
+      />
+      <ErrorMessage component={FormikElements.Error} name="phoneNumber" />
+
+
       <FastField
         component={FormikElements.Select}
         creatable={true}

diff --git a/src/features/Application/ManageApplicationForm.tsx b/src/features/Application/ManageApplicationForm.tsx
@@ -1179,18 +1179,6 @@ const ManageApplicationForm: React.FunctionComponent<
               </GridTwoColumn>
             </>
           ) : null}
-
-          <div className="eventPrompt">
-            Make sure to mark yourself as going to our{' '}
-            <a
-              href={CONSTANTS.FACEBOOK_EVENT_URL}
-              target="_blank"
-              rel="noopener noreferrer"
-            >
-              Facebook event
-            </a>
-            !
-          </div>
         </div>
 
         <div className="buttons">