Skip to content

[query] Remove lookupOrCompileCachedFunction from Backend interface #14691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 19, 2025
Merged

[query] Remove lookupOrCompileCachedFunction from Backend interface #14691

merged 1 commit into from
Feb 19, 2025

Conversation

@ehigham
Copy link
Member

@ehigham ehigham commented Sep 17, 2024 •
edited
Loading

In the spirit of shrinking the Backend functionality to a core set of functions, move code cache access via execute context.

This was referenced Sep 17, 2024
Merged
Merged
@ehigham Graphite App
Copy link
Member Author

ehigham commented Sep 17, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

This was referenced Sep 17, 2024
Merged
Merged
@ehigham ehigham marked this pull request as ready for review September 17, 2024 23:58
This was referenced Sep 18, 2024
Merged
Closed
@ehigham ehigham force-pushed the ehigham/ctx-bm-cache branch from b0be25e to 6038f9b Compare September 19, 2024 20:52
@ehigham ehigham force-pushed the ehigham/ctx-code-cache branch from a47ef8b to 1530549 Compare September 19, 2024 20:53
This was referenced Sep 20, 2024
Merged
Merged
@ehigham ehigham force-pushed the ehigham/ctx-bm-cache branch from 6038f9b to 15f2275 Compare October 1, 2024 19:44
@ehigham ehigham force-pushed the ehigham/ctx-code-cache branch from 1530549 to d3a662f Compare October 1, 2024 19:45
@ehigham ehigham force-pushed the ehigham/ctx-bm-cache branch from 15f2275 to 71fcb35 Compare October 1, 2024 20:03
@ehigham ehigham force-pushed the ehigham/ctx-code-cache branch from d3a662f to f00e349 Compare October 1, 2024 20:03
@ehigham ehigham force-pushed the ehigham/ctx-bm-cache branch from 71fcb35 to 360af7c Compare October 8, 2024 19:18
@ehigham ehigham force-pushed the ehigham/ctx-code-cache branch from f00e349 to 532bd55 Compare October 8, 2024 19:18
@ehigham ehigham force-pushed the ehigham/ctx-bm-cache branch from 360af7c to d16f9c6 Compare October 8, 2024 20:30
@ehigham ehigham force-pushed the ehigham/ctx-code-cache branch from 532bd55 to 324bae5 Compare October 8, 2024 20:30
@ehigham ehigham force-pushed the ehigham/ctx-bm-cache branch from d16f9c6 to 783df28 Compare October 16, 2024 20:02
@ehigham ehigham force-pushed the ehigham/ctx-code-cache branch from 324bae5 to 7e738cc Compare October 16, 2024 20:02
@ehigham ehigham mentioned this pull request Oct 16, 2024
Merged
@ehigham ehigham force-pushed the ehigham/ctx-bm-cache branch from 783df28 to 7e661e4 Compare October 16, 2024 21:30
@ehigham ehigham force-pushed the ehigham/ctx-code-cache branch from 7e738cc to 8fd036a Compare October 16, 2024 21:30
@ehigham ehigham mentioned this pull request Oct 17, 2024
Closed
1 task
@ehigham ehigham force-pushed the ehigham/ctx-bm-cache branch from 7e661e4 to 952b01d Compare October 17, 2024 15:00
@ehigham ehigham force-pushed the ehigham/ctx-code-cache branch from 8fd036a to a3aae4a Compare October 17, 2024 15:00
@ehigham ehigham force-pushed the ehigham/ctx-bm-cache branch from 952b01d to a265389 Compare October 21, 2024 15:24
@ehigham ehigham force-pushed the ehigham/ctx-code-cache branch from a3aae4a to 525c3e7 Compare October 21, 2024 15:24
@ehigham ehigham force-pushed the ehigham/ctx-bm-cache branch from af242c2 to 13a8e28 Compare January 29, 2025 21:40
@ehigham ehigham force-pushed the ehigham/ctx-code-cache branch from 8a1bcf9 to c86812f Compare January 29, 2025 21:40
@ehigham ehigham force-pushed the ehigham/ctx-bm-cache branch from 13a8e28 to 97d43aa Compare January 30, 2025 19:52
@ehigham ehigham force-pushed the ehigham/ctx-code-cache branch from c86812f to 23be511 Compare January 30, 2025 19:52
@ehigham ehigham force-pushed the ehigham/ctx-bm-cache branch from 97d43aa to 4b0ea93 Compare January 31, 2025 19:12
@ehigham ehigham force-pushed the ehigham/ctx-code-cache branch from 23be511 to 5654839 Compare January 31, 2025 19:12
@ehigham ehigham force-pushed the ehigham/ctx-bm-cache branch from 4b0ea93 to 5ff3aee Compare January 31, 2025 19:27
@ehigham ehigham force-pushed the ehigham/ctx-code-cache branch from 5654839 to 2956a6b Compare January 31, 2025 19:27
@ehigham ehigham force-pushed the ehigham/ctx-bm-cache branch from 5ff3aee to 5db76b7 Compare January 31, 2025 21:21
@ehigham ehigham force-pushed the ehigham/ctx-code-cache branch from 2956a6b to d970a8b Compare January 31, 2025 21:21
@ehigham ehigham force-pushed the ehigham/ctx-bm-cache branch from 5db76b7 to 5264833 Compare February 3, 2025 17:20
@ehigham ehigham force-pushed the ehigham/ctx-code-cache branch from d970a8b to 0a3e70c Compare February 3, 2025 17:20
@ehigham ehigham force-pushed the ehigham/ctx-bm-cache branch from 5264833 to 057c2a1 Compare February 3, 2025 18:00
@ehigham ehigham force-pushed the ehigham/ctx-code-cache branch from 0a3e70c to d0d4917 Compare February 3, 2025 18:00
@ehigham ehigham force-pushed the ehigham/ctx-bm-cache branch from 057c2a1 to ee87129 Compare February 3, 2025 20:51
@ehigham ehigham force-pushed the ehigham/ctx-code-cache branch from d0d4917 to ee399d1 Compare February 3, 2025 20:51
@ehigham ehigham force-pushed the ehigham/ctx-bm-cache branch from ee87129 to ee31986 Compare February 4, 2025 22:44
@ehigham ehigham force-pushed the ehigham/ctx-code-cache branch from ee399d1 to d56d118 Compare February 4, 2025 22:44
Base automatically changed from ehigham/ctx-bm-cache to main February 4, 2025 23:26
@ehigham ehigham force-pushed the ehigham/ctx-code-cache branch from d56d118 to be3e8f8 Compare February 6, 2025 18:44
patrick-schultz
patrick-schultz approved these changes Feb 14, 2025
View reviewed changes
Copy link
Member

@patrick-schultz patrick-schultz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great simple change. I especially like killing the duplicated Compile code

chrisvittal
chrisvittal approved these changes Feb 19, 2025
View reviewed changes
Copy link
Collaborator

@chrisvittal chrisvittal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done. LGTM

@hail-ci-robot hail-ci-robot merged commit 95db3f4 into main Feb 19, 2025
2 of 3 checks passed
@hail-ci-robot hail-ci-robot deleted the ehigham/ctx-code-cache branch February 19, 2025 20:44
@ehigham ehigham mentioned this pull request Mar 18, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@patrick-schultz patrick-schultz patrick-schultz approved these changes

@chrisvittal chrisvittal chrisvittal approved these changes

Assignees

@patrick-schultz patrick-schultz

@chrisvittal chrisvittal

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ehigham @patrick-schultz @chrisvittal @hail-ci-robot