Skip to content

Conversation

@ehigham
Copy link
Member

@ehigham ehigham commented Dec 5, 2024

Change Description

Added benchmark parameters to all benchmark tests in the Hail codebase. Each test now specifies:

  • Minimum detectable slowdown (mds)
  • Number of instances (ie number of batch jobs)
  • Number of iterations (how many timed trials of the benchmark per instance)
  • Number of burn-in iterations (number of untimed trials run before timing)

These parameters allow for more precise and controlled benchmark measurements by explicitly defining the statistical requirements and execution parameters for each test.

Security Assessment

This change has no security impact

Impact Description

Low-level test configuration changes only - modifies benchmark test parameters without changing any functional code or test logic.

Copy link
Member Author

ehigham commented Dec 5, 2024

@ehigham ehigham force-pushed the ehigham/benchmark-suite-improvements branch from 54cd48a to 93e81d9 Compare December 5, 2024 21:16
@ehigham ehigham force-pushed the ehigham/benchmark-configurations branch from fa2e947 to 8b98a0c Compare December 5, 2024 21:16
@ehigham ehigham force-pushed the ehigham/benchmark-suite-improvements branch from 93e81d9 to 2344aed Compare December 5, 2024 21:19
@ehigham ehigham force-pushed the ehigham/benchmark-configurations branch from 8b98a0c to 692247b Compare December 5, 2024 21:20
@ehigham ehigham force-pushed the ehigham/benchmark-suite-improvements branch from 2344aed to e8cb1fb Compare December 5, 2024 21:42
@ehigham ehigham force-pushed the ehigham/benchmark-configurations branch from 692247b to e638c1c Compare December 5, 2024 21:42
@ehigham ehigham force-pushed the ehigham/benchmark-suite-improvements branch from e8cb1fb to c4a8c24 Compare December 5, 2024 21:52
@ehigham ehigham force-pushed the ehigham/benchmark-configurations branch from e638c1c to 8bad700 Compare December 5, 2024 21:53
@ehigham ehigham force-pushed the ehigham/benchmark-suite-improvements branch from c4a8c24 to 687437c Compare December 5, 2024 22:00
@ehigham ehigham force-pushed the ehigham/benchmark-configurations branch from 8bad700 to 69cfc52 Compare December 5, 2024 22:00
@ehigham ehigham changed the base branch from ehigham/benchmark-suite-improvements to ehigham/benchmark-in-batch-variability December 5, 2024 22:01
@ehigham ehigham force-pushed the ehigham/benchmark-in-batch-variability branch from 2c72cb5 to 30d0a86 Compare December 5, 2024 22:06
@ehigham ehigham force-pushed the ehigham/benchmark-configurations branch from 69cfc52 to f5b2196 Compare December 5, 2024 22:06
@ehigham ehigham force-pushed the ehigham/benchmark-in-batch-variability branch from 30d0a86 to e32bc09 Compare December 5, 2024 22:12
@ehigham ehigham force-pushed the ehigham/benchmark-configurations branch from f5b2196 to 0d886d5 Compare December 5, 2024 22:13
@ehigham ehigham force-pushed the ehigham/benchmark-in-batch-variability branch from e32bc09 to 97a40fa Compare December 6, 2024 23:13
@ehigham ehigham force-pushed the ehigham/benchmark-configurations branch from 0d886d5 to 432a727 Compare December 6, 2024 23:13
@ehigham ehigham marked this pull request as ready for review December 6, 2024 23:14
@ehigham ehigham force-pushed the ehigham/benchmark-in-batch-variability branch from 97a40fa to 1118f03 Compare December 12, 2024 21:52
@ehigham ehigham force-pushed the ehigham/benchmark-configurations branch from 432a727 to b1f3066 Compare December 12, 2024 21:52
@ehigham ehigham force-pushed the ehigham/benchmark-in-batch-variability branch from 1118f03 to f79f8c1 Compare December 12, 2024 22:01
@ehigham ehigham force-pushed the ehigham/benchmark-configurations branch from b1f3066 to 2299a17 Compare December 12, 2024 22:01
@ehigham ehigham force-pushed the ehigham/benchmark-in-batch-variability branch from f79f8c1 to af0036a Compare December 12, 2024 22:03
@ehigham ehigham force-pushed the ehigham/benchmark-configurations branch from 2299a17 to a128b0f Compare December 12, 2024 22:03
@ehigham ehigham force-pushed the ehigham/benchmark-in-batch-variability branch from af0036a to e61f806 Compare December 16, 2024 18:50
@ehigham ehigham force-pushed the ehigham/benchmark-configurations branch from a128b0f to db53a7e Compare December 16, 2024 18:50
@ehigham ehigham force-pushed the graphite-base/14762 branch 2 times, most recently from 414978c to 1986d7c Compare October 29, 2025 20:22
@ehigham ehigham force-pushed the ehigham/benchmark-configurations branch from b87f62e to 7c66b5b Compare October 29, 2025 20:22
@ehigham ehigham changed the base branch from graphite-base/14762 to ehigham/benchmark-in-batch-variability October 29, 2025 20:22
@ehigham ehigham force-pushed the ehigham/benchmark-configurations branch 2 times, most recently from 1384f98 to 1ffbf2e Compare October 30, 2025 18:22
@ehigham ehigham force-pushed the ehigham/benchmark-in-batch-variability branch from 1986d7c to e06b0cf Compare October 30, 2025 18:22
@ehigham ehigham force-pushed the ehigham/benchmark-configurations branch from 1ffbf2e to 0639225 Compare October 30, 2025 19:16
@ehigham ehigham force-pushed the ehigham/benchmark-in-batch-variability branch 2 times, most recently from 9834528 to 3e73c20 Compare October 30, 2025 19:24
@ehigham ehigham force-pushed the ehigham/benchmark-configurations branch 2 times, most recently from a7638c7 to b3c3c7b Compare October 30, 2025 19:40
@ehigham ehigham force-pushed the ehigham/benchmark-in-batch-variability branch 2 times, most recently from 5b40645 to 79c3abc Compare October 30, 2025 19:47
@ehigham ehigham force-pushed the ehigham/benchmark-configurations branch 2 times, most recently from 08ee600 to 2bc073b Compare October 30, 2025 20:04
@ehigham ehigham force-pushed the ehigham/benchmark-in-batch-variability branch from 79c3abc to 794a3a6 Compare October 30, 2025 20:04
@ehigham ehigham force-pushed the ehigham/benchmark-configurations branch from 2bc073b to ae40a76 Compare October 30, 2025 20:55
@ehigham ehigham force-pushed the ehigham/benchmark-in-batch-variability branch 2 times, most recently from 9887a32 to 479faad Compare October 31, 2025 01:00
@ehigham ehigham force-pushed the ehigham/benchmark-configurations branch 2 times, most recently from e95373a to 04edb81 Compare October 31, 2025 15:08
@ehigham ehigham force-pushed the ehigham/benchmark-in-batch-variability branch from 479faad to db2fcaa Compare October 31, 2025 15:08
@ehigham ehigham force-pushed the ehigham/benchmark-configurations branch from 04edb81 to 8521f54 Compare October 31, 2025 15:25
@ehigham ehigham force-pushed the ehigham/benchmark-in-batch-variability branch from db2fcaa to 773b3aa Compare October 31, 2025 15:25
@ehigham ehigham force-pushed the ehigham/benchmark-configurations branch from 8521f54 to b568e50 Compare October 31, 2025 16:28
@ehigham ehigham force-pushed the ehigham/benchmark-in-batch-variability branch from 773b3aa to 6748751 Compare October 31, 2025 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants