[compiler] refactor typecheck/infertype #14986
Draft
+1,769
−1,649
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrick-schultz
force-pushed
the
ps/push-zuyqkxwuqsuk
branch
from
deae0b3 to
ab8aa97
Compare
IR nodes can't have mutable args. Override apply methods to call inferType. Remove all assertions from inferType, only computes node's type from children types. Rewrite TypeCheck to not redundantly assert result type that was computed by inferType. Add "untyped" constructors, only used in parser Allow ir-gen to specialize type of `typ`, get rid of `TypedIR` Make `typ` a constructor arg of all nodes, removing all mutability. Break up ComputeTypeFromChildren into separate methods callable without constructing a node.
patrick-schultz
force-pushed
the
ps/push-zuyqkxwuqsuk
branch
from
ab8aa97 to
9a6ea16
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
Security Assessment
This change cannot impact the Hail Batch instance as deployed by Broad Institute in GCP