Skip to content

[query/vds] Actually use _assert_type in read_vds #15002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[query/vds] Actually use _assert_type in read_vds #15002

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 13 additions & 5 deletions hail/python/hail/vds/variant_dataset.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,15 +31,23 @@ def read_vds(
:class:`.VariantDataset`
"""
if intervals or not n_partitions:
reference_data = hl.read_matrix_table(VariantDataset._reference_path(path), _intervals=intervals)
variant_data = hl.read_matrix_table(VariantDataset._variants_path(path), _intervals=intervals)
reference_data = hl.read_matrix_table(
VariantDataset._reference_path(path), _intervals=intervals, _assert_type=_assert_reference_type
)
variant_data = hl.read_matrix_table(
VariantDataset._variants_path(path), _intervals=intervals, _assert_type=_assert_variant_type
)
else:
assert n_partitions is not None
reference_data = hl.read_matrix_table(VariantDataset._reference_path(path))
reference_data = hl.read_matrix_table(VariantDataset._reference_path(path), _assert_type=_assert_reference_type)
intervals = reference_data._calculate_new_partitions(n_partitions)
assert len(intervals) > 0
reference_data = hl.read_matrix_table(VariantDataset._reference_path(path), _intervals=intervals)
variant_data = hl.read_matrix_table(VariantDataset._variants_path(path), _intervals=intervals)
reference_data = hl.read_matrix_table(
VariantDataset._reference_path(path), _intervals=intervals, _assert_type=reference_data._type
)
variant_data = hl.read_matrix_table(
VariantDataset._variants_path(path), _intervals=intervals, _assert_type=_assert_variant_type
)

# if LEN is missing, add it, _add_len is a no-op if LEN is already present
reference_data = VariantDataset._add_len(reference_data)
Expand Down