Skip to content

Conversation

@ehigham
Copy link
Member

@ehigham ehigham commented Sep 19, 2025

HailContext jihad:

  • moves logging configuration from HailContext to a dedicated Logging object.
  • removes references to HailContext.version

This change cannot impact the Hail Batch instance as deployed by Broad Institute in GCP

@ehigham ehigham marked this pull request as ready for review September 19, 2025 16:04
@ehigham ehigham changed the title [query] move configureLogging out of HailContext [query] move configureLogging and version out of HailContext Sep 19, 2025
@ehigham ehigham force-pushed the ehigham/move-configure-logging-out-of-hail-context branch from bffda9c to 4763fac Compare September 23, 2025 19:37
Copy link
Collaborator

@chrisvittal chrisvittal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this change.

@ehigham ehigham force-pushed the ehigham/move-configure-logging-out-of-hail-context branch from 4763fac to 881f910 Compare September 25, 2025 01:53
@ehigham ehigham force-pushed the ehigham/move-read-partitions-into-block-matrix branch from ae16698 to 8aa0933 Compare September 25, 2025 01:53
@ehigham ehigham force-pushed the ehigham/move-configure-logging-out-of-hail-context branch from 881f910 to 39ddc1e Compare September 25, 2025 13:49
@ehigham ehigham force-pushed the ehigham/move-read-partitions-into-block-matrix branch from 8aa0933 to 09b108a Compare September 25, 2025 13:49
@ehigham ehigham force-pushed the ehigham/move-configure-logging-out-of-hail-context branch from 39ddc1e to cc76fed Compare September 25, 2025 16:30
@ehigham ehigham force-pushed the ehigham/move-read-partitions-into-block-matrix branch 2 times, most recently from 71881ea to 188e42f Compare September 25, 2025 16:47
@ehigham ehigham force-pushed the ehigham/move-configure-logging-out-of-hail-context branch 2 times, most recently from 7b9b10e to 0a1f47e Compare September 25, 2025 17:08
@ehigham ehigham force-pushed the ehigham/move-read-partitions-into-block-matrix branch 2 times, most recently from 3fffddb to d699931 Compare September 25, 2025 17:09
@ehigham ehigham force-pushed the ehigham/move-configure-logging-out-of-hail-context branch 2 times, most recently from 046213b to 6924e88 Compare September 25, 2025 18:37
@ehigham ehigham force-pushed the ehigham/move-read-partitions-into-block-matrix branch from d699931 to 4ce1680 Compare September 25, 2025 18:37
Copy link
Member

@patrick-schultz patrick-schultz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely nicer

@ehigham ehigham force-pushed the ehigham/move-configure-logging-out-of-hail-context branch from 6924e88 to fb861eb Compare September 26, 2025 01:06
@ehigham ehigham force-pushed the ehigham/move-read-partitions-into-block-matrix branch from 4ce1680 to 00a2f37 Compare September 26, 2025 01:06
Base automatically changed from ehigham/move-read-partitions-into-block-matrix to main September 26, 2025 01:55
@ehigham ehigham force-pushed the ehigham/move-configure-logging-out-of-hail-context branch from fb861eb to 5eb5b64 Compare September 26, 2025 02:21
@hail-ci-robot hail-ci-robot merged commit ff8b149 into main Sep 26, 2025
2 checks passed
@hail-ci-robot hail-ci-robot deleted the ehigham/move-configure-logging-out-of-hail-context branch September 26, 2025 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants