-
Notifications
You must be signed in to change notification settings - Fork 257
[query] move configureLogging and version out of HailContext
#15098
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
hail-ci-robot
merged 2 commits into
main
from
ehigham/move-configure-logging-out-of-hail-context
Sep 26, 2025
Merged
[query] move configureLogging and version out of HailContext
#15098
hail-ci-robot
merged 2 commits into
main
from
ehigham/move-configure-logging-out-of-hail-context
Sep 26, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 19, 2025
Member
Author
configureLogging out of HailContextconfigureLogging and version out of HailContext
This was referenced Sep 19, 2025
bffda9c to
4763fac
Compare
chrisvittal
approved these changes
Sep 24, 2025
Collaborator
chrisvittal
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this change.
4763fac to
881f910
Compare
ae16698 to
8aa0933
Compare
881f910 to
39ddc1e
Compare
8aa0933 to
09b108a
Compare
39ddc1e to
cc76fed
Compare
71881ea to
188e42f
Compare
7b9b10e to
0a1f47e
Compare
3fffddb to
d699931
Compare
046213b to
6924e88
Compare
d699931 to
4ce1680
Compare
patrick-schultz
approved these changes
Sep 25, 2025
Member
patrick-schultz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Definitely nicer
6924e88 to
fb861eb
Compare
4ce1680 to
00a2f37
Compare
Base automatically changed from
ehigham/move-read-partitions-into-block-matrix
to
main
September 26, 2025 01:55
fb861eb to
5eb5b64
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

HailContextjihad:HailContextto a dedicatedLoggingobject.HailContext.versionThis change cannot impact the Hail Batch instance as deployed by Broad Institute in GCP