[query] Simplify BlockMatrix transpose IR generation #15147
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BlockMatrix IR is a little wierd right now. We often try to treat matricies with a single row/column as a vector. This leads to a lot of additional complexity for little benefit. As as start to simplifying this, always use `[1, 0]` as the index expression to BlockMatrixBroadcast in transpose.
|
Related to #15140 since in the vector case, we would allow broadcasts of row vectors as col vectors, and so, in the sparse case, defined block calculations would still be wrong. |
patrick-schultz
approved these changes
Oct 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BlockMatrix IR is a little wierd right now. We often try to treat matricies with a single row/column as a vector. This leads to a lot of additional complexity for little benefit. As as start to simplifying this, always use
[1, 0]as the index expression to BlockMatrixBroadcast in transpose.Security Assessment