Open
Conversation
Otherwise, any error output is hidden from the user, which makes debugging difficult. I didn't use the a2ps print menu yet, but its process call is ``` emacs-lisp (make-process :name "a2ps-print" :buffer buffer :stderr buffer :connection-type 'pipe :command cmd) ``` so it also shows you the stderr in a buffer. For lp the normal stdout might not be so useful, so it's fine not having and stdout buffer there.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Otherwise, any error output is hidden from the user, which makes debugging difficult.
I didn't use the a2ps print menu yet, but its process call is
so it also shows you the stderr in a buffer. For lp the normal stdout might not
be so useful, so it's fine not having and stdout buffer there, but I would prefer having the stderr in a separate buffer.
What I haven't implemented yet but would be nice is to also give a warning in case of an error with a hint to check out the error buffer for more information. Like what
magitdoes if a commit or push fails.