Skip to content

Commit

Permalink
Switch from blur to input for adding new rows, closes #3.
Browse files Browse the repository at this point in the history
New rows get added as soon as the user inputs a number into the field.
  • Loading branch information
hal7df committed Sep 6, 2017
1 parent 6ed7f49 commit afae50a
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 8 deletions.
4 changes: 2 additions & 2 deletions index.html
Original file line number Diff line number Diff line change
Expand Up @@ -93,8 +93,8 @@ <h2 class="mdl-card__title-text">Plot settings</h2>
</thead>
<tbody>
<tr data-rownum="0" data-needed="xy">
<td contentEditable="true" class="x" onblur="page.datasets.update(event)" onkeydown="page.datasets.mask(event)"></td>
<td contentEditable="true" class="y" data-setnum="0" onblur="page.datasets.update(event)" onkeydown="page.datasets.mask(event)"></td>
<td contentEditable="true" class="x" oninput="page.datasets.update(event)" onkeydown="page.datasets.mask(event)"></td>
<td contentEditable="true" class="y" data-setnum="0" oninput="page.datasets.update(event)" onkeydown="page.datasets.mask(event)"></td>
</tr>
</tbody>
</table>
Expand Down
9 changes: 3 additions & 6 deletions js/page.js
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@ var page = {
min.MaterialTextfield.change("");
max.MaterialTextfield.change("");

//Run graph autoscale logic
//TODO: Run graph autoscale logic
} else {
min.MaterialTextfield.enable();
max.MaterialTextfield.enable();
Expand Down Expand Up @@ -179,9 +179,6 @@ var page = {
var row = parseInt(event.target.parentElement.dataset.rownum, 10);
var data = page._data.data;
var dataNeeded = event.target.parentElement.dataset.needed;
var yTest = function (arr) {
return !(arr[row] === null || arr[row] === undefined);
};

if (event.target.classList.contains('x')) {
if (event.target.textContent.length > 0) {
Expand Down Expand Up @@ -215,8 +212,8 @@ var page = {
var createCell = function (colnum) {
var cell = document.createElement("td");
cell.contentEditable = "true";
cell.onblur = page.datasets.update;
cell.onkeydown = page.datasets.mask;
cell.addEventListener("input", page.datasets.update);
cell.addEventListener("keydown", page.datasets.mask);
cell.classList.add(colnum === undefined ? "x" : "y");
if (colnum !== undefined) cell.dataset.setnum = colnum;
return cell;
Expand Down

0 comments on commit afae50a

Please sign in to comment.